On 1/25/2011 2:10 PM, Vladimir Prus wrote:
Eric Niebler wrote:
May I ask for permission to remove the files instead of poisoning them? The risk is the same, but the result much more desirable...
Sorry, no. We have a way to avoid changing build files just before release. Let's take it.
That does not seem reasonable to me. IIUC, the changes to build files involve remove N tests, which is a low-risk change that can be fully validated locally. Leaving broken code in seems much worse.
The question to answer is: was the original issue a showstopper or not? I had decided it was not because it breaks no code in the field. That seems reasonable to me. And if you disagreed, the time to speak up was days ago. -- Eric Niebler BoostPro Computing http://www.boostpro.com