
15 Mar
2010
15 Mar
'10
4:53 a.m.
Mateusz Loskot wrote:
Roland Bock wrote:
Mateusz Loskot wrote: [snip]
I forgotten about -Wextra option and now GCC 4.4.1 reports the same worning, indeed. I was wrong, the assert macro is not that clever as I suggested
$ g++ -E -pedantic -Wall -Wextra -DNDEBUG test.cpp int main() { int* p = 0; (static_cast<void> (0)); // assert macro }
$ g++ -pedantic -Wall -Wextra -DNDEBUG test.cpp test.cpp: In function ‘int main()’: test.cpp:4: warning: unused variable ‘p’
So what do you think of my re-definition?
It's OK, but personally I would not redefine the assert macro, but define it as a new enhanced macro for use in my project
#define MYLIB_ASSERT(cond)
Best regards,
You're right, re-definition is bound to lead to confusion. Regards, Roland