On Tue, Jun 2, 2015 at 5:41 PM, James Armstrong <armstrhu@gmail.com> wrote:
After getting some really good feedback, I think I have settled into something that is efficient, has a nice clean interface, and provides some useful capabilities. I am hoping people can take a look at the code, test it out, and provide an additional feedback in terms of interface, implementation, bugs, or additional features/classes that would be useful.
Unless I missed something, I don't see anything that deletes container_ on destruction in heterovector's implementation. And the two delete's that are there (in setEQUALTO) are wrong. You can't delete a void* directly. (Why is it a void*, anyway?) Moreover, I don't understand the chosen implementation strategy at all. As far as I can see, this can be implemented simply by storing a `std::tuple<std::vector<Ts>...>`. All that's needed is something that finds the index of the Nth T in Ts..., which is easy to write. Tim