On 03/31/2011 12:44 PM, Daniel James wrote:
On 31 March 2011 09:09, Gordon Woodhull<gordon@woodhull.com> wrote:
Not to be snarky, but I agree with the review results:
Critical issues ===============
Use of a custom lambda implementation was pointed by many as not great -- we already have a couple, so let's not add more to the mix.
It's possible that some of the "must fix" issues from a review can be fixed after release, though, right?
A library needs to satisfy the requirements from its review before it's added to trunk. But it could have used phoenix 2 to do that - if only to get the library in trunk and the regression tests running (which should be done as soon as possible). Anyway, phoenix 3 is in trunk now.
There wasn't much point in porting to Boost.Phoenix2 knowing it would be superseded soon. After all, the Boost.Log lambda expressions do their job well enough, so this improvement does not seem very critical.