Jens Seidel wrote:
On Fri, Feb 08, 2008 at 04:31:39PM +0000, Phil Endecott wrote:
John Torjo wrote:
Someone else told me privately about these - I fixed them but did not commit. However, I've committed the changes now - please take the latest version
from SVN.
Done, thanks. Here's the next batch: unsigned vs. signed comparisons:
John, please try to test your code before you commit. There are even some
I always do that - unfortunately MSVC did not complain. gcc did not complain either. I've just added -W -Wall so that I catch all these "cool" warnings. p.s. sorry about syslog - did not test it since I don't have linux. Here's the latest compilation: Compiler: gcc 4.1 Building Makefile: "D:\john\code\boost_sandbox\logging\libs\logging\internal\gcc\Makefile.win" Executing make... make.exe -f "D:\john\code\boost_sandbox\logging\libs\logging\internal\gcc\Makefile.win" all g++.exe -c main.cpp -o main.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/one_loger_one_filter.cpp -o ../../samples/scenarios/one_loger_one_filter.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/custom_fmt_dest.cpp -o ../../samples/scenarios/custom_fmt_dest.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/fastest_no_ostr_like.cpp -o ../../samples/scenarios/fastest_no_ostr_like.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/fastest_use_ostr_like.cpp -o ../../samples/scenarios/fastest_use_ostr_like.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/mul_levels_mul_logers.cpp -o ../../samples/scenarios/mul_levels_mul_logers.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/mul_levels_one_logger.cpp -o ../../samples/scenarios/mul_levels_one_logger.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/mul_loggers_one_filter.cpp -o ../../samples/scenarios/mul_loggers_one_filter.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/no_levels_with_route.cpp -o ../../samples/scenarios/no_levels_with_route.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/your_scenario.cpp -o ../../samples/scenarios/your_scenario.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/ded_loger_one_filter.cpp -o ../../samples/scenarios/ded_loger_one_filter.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/ts_loger_one_filter.cpp -o ../../samples/scenarios/ts_loger_one_filter.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/using_tags.cpp -o ../../samples/scenarios/using_tags.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall g++.exe -c ../../samples/scenarios/use_tss_ostringstream.cpp -o ../../samples/scenarios/use_tss_ostringstream.o -I".." -I"D:/boosts/boost_1_33_1" -I"C:/mingw/include/c++/4.1.2/backward" -I"C:/mingw/include/c++/4.1.2" -I"C:/mingw/include/c++" -I"C:/mingw/include" -I"." -I"../../../.." -W -Wall
errors in namespaces which cause trouble during compilation. I attached a trivial patch.
I tested beside header files using my check_boost script also all *.cpp files using
for i in $(find -name "*.cpp"); do /usr/lib/gcc-snapshot/bin/g++ -Wall -O3 -Wno-long-long -W -pedantic -I /home/jens/Programme/Entwicklung/Boost/svn/logging/ -I /home/jens/Programme/Entwicklung/Boost/svn/trunk/ $i -c -o /tmp/test.o; done | tee /tmp/log
and got the attached output. You can probably indeed not fix all warnings such as
warning: type qualifiers ignored on function return type
which results from code like: template<class T> T function(T) { return T() }
I'll look at it
with T = const char. Changing the return value from const char to char would fix this problem.
Also look at
/usr/lib/gcc-snapshot/lib/gcc/i486-linux-gnu/4.3.0/../../../../include/c++/4.3.0/bits/stl_algo.h: In function 'char* boost::debug::<unnamed>::prepare_window_title(const boost::debug::dbg_startup_info&)': /usr/lib/gcc-snapshot/lib/gcc/i486-linux-gnu/4.3.0/../../../../include/c++/4.3.0/bits/stl_algo.h:202: warning: array subscript is above array bounds
It's somewhere in Boost.Test but since snprintf is properly used I don't understand the warning.
I'll look at it
PS: Please wrap your lines. Parts of the patch will be unreadable for you because some lines are just too long.
The patch was just fine ;) Best, John
Jens
------------------------------------------------------------------------
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
-- http://John.Torjo.com -- C++ expert http://blog.torjo.com ... call me only if you want things done right