-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 AMDG On 04/06/2011 02:29 PM, Chad Nelson wrote:
Please explicitly state in your review whether the library should be accepted.
*Yes, the Locale library should be accepted into Boost.*
- What is your evaluation of the design? - What is your evaluation of the implementation?
The design appears well thought out and the implementation is solid.
- What is your evaluation of the documentation?
The tutorial was sufficient to understand what the library could do. The reference could use more attention to details like preconditions, postconditions, exception guarantees, limitations, and so on.
- What is your evaluation of the potential usefulness of the library?
Who needs anything other than en-US anyway?
- Did you try to use the library? With what compiler? Did you have any problems?
No. I didn't try it.
- How much effort did you put into your evaluation? A glance? A quick reading? In-depth study?
I spent about 20 hours reading the entire code base carefully.
- Are you knowledgeable about the problem domain?
No. In Christ, Steven Watanabe -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNp709AAoJEDTBQuhymLHSEYEH/231DU5CFAVZ2XJ4GnY2JZXG DfL7Xmv6SeOOEKNoJcsh3fu/uDAiqdH5tWw9aJPNiBBPZveUYbHq4UZ5/hCCZtMM STUZnW+LPPsqNiWchRy3PTiAFFFJMqZPjMOsal76fQMqUY6Pm4OGbKbgVSrwiKoG 1R5UeVFXJYo5fO5x5LOkfxFQdI8j3l/OVesd84sR0F6Pm4YgeH1LZ3xLgVl2nO2k JnSeXKe4xAnebdSDzA7oCPpa2CDqJnKBphGz+H1cWRbIbUSOzDwmXZ21Ec973Aq7 dlr8s4CP9hcYOIAzzDWDd8RXKxBg1X5sDDxYQe4UMKZdEkiv//tyStHlG+QugGY= =PEw0 -----END PGP SIGNATURE-----