Hi Jens,
not sure whether you are also interested in my feedback as you ignored already two mails from me with simple patches. Nevertheless I attached my mail again ...
Sorry 'bout that - it's not my fault - though I should have replied to the mailing list. The idea is I definitely took your comments into account - and you'll see that if you take a look at the latest sources. Here's the problem (when I replied to your email): This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a permanent error. The following address(es) failed: jensseidel@users.sf.net SMTP error from remote mail server after RCPT TO:<jensseidel@users.sf.net>: host mail.sourceforge.net [66.35.250.206]: 550-Postmaster verification failed while checking <john.code@torjo.com> 550-Called: 72.52.140.12 550-Sent: RCPT TO:<postmaster@torjo.com> 550-Response: 550 No such email address 550-Several RFCs state that you are required to have a postmaster 550-mailbox for each mail domain. This host does not accept mail 550-from domains whose servers reject the postmaster address. 550 Sender verify failed Here's the original message: Return-path: <john.code@torjo.com> Received: from [89.40.140.91] (port=2249) by europe.hosted4ever.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.66) (envelope-from <john.code@torjo.com>) id 1IiOav-00047P-Gd; Thu, 18 Oct 2007 09:11:00 +0300 Message-ID: <4716F8E9.3050504@torjo.com> Date: Thu, 18 Oct 2007 09:10:49 +0300 From: John Torjo <john.code@torjo.com> User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Jens Seidel <jensseidel@users.sf.net> Subject: Re: Comments to Boost.Log2 References: <20071017113038.GA31530@imkf-pc073.imkf.tu-freiberg.de> In-Reply-To: <20071017113038.GA31530@imkf-pc073.imkf.tu-freiberg.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Jens,
Hi John,
I was very surprised to read today on your homepage that you continue
Thanks ;) It's been a crazy time for me, but I'm finally coping :)
working on Boost.log. Great! I suggest you announce it on the boost-user list.
Good point . First, I need to subscribe to it :)
On this list I recently posted a few comments for you, as I failed in the past to contact you (and considered the project death). See http://lists.boost.org/boost-users/2007/09/30970.php
I've seen them now - you're right about the levels stuff - I've corrected it in v2. I'm not maintaining v1 since v2 is sooooo much better!
OK, a few further comments to your new version 2: * The zip archive contains object files. Please remove these.
Sorry 'bout that - I think I've removed them already. Anyway, could you give me the file names, just to make sure I don't miss them in the future?
* Are you aware that the licenses of e.g. lib/logging/tests/template.cpp and boost/logging/defaults.hpp are different? Is this wanted?
* Some code contains: "See accompanying file LICENSE_1_0.txt". I miss this file in your archive.
done
* "generating the docs.txt" Please avoid using spaces in names. You are probably aware that a few filesystems are not able to store such files (e.g. ISO 9660 without Rock Ridge or Joliet extensions). It makes writing shell scripts also harder as a space is a word separator in most shells (e.g. bash) (for file in *; do ...).
done
* I attached a patch which allows your test code to be compiled by fixing errors and warnings. A single warning remains which I marked in the code in a comment.
Yup, thanks - fixed it.
I added a Makefile to simplify the task of compiling. Read it to see the compiler flags I used. Used compiler: $ /usr/lib/gcc-snapshot/bin/g++ --version g++ (Debian 20070916-1) 4.3.0 20070916 (experimental) [trunk revision 128522]
Thanks for the makefile - unfortunately I can't use it because boost uses jam - so I need to somehow make a jamfile to build the tests :) Note: the modifications are in SVN: http://svn.boost.org/svn/boost/sandbox/logging/ (I update the .zip file only once in a while - like, every 2 weeks or so :) ) Best, John And more info : http://torjo.blogspot.com/2007/10/email-hell.html Best, John -- http://John.Torjo.com -- C++ expert ... call me only if you want things done right