On Monday 08 September 2008 19:33, Stjepan Rajko wrote:
Hello,
In trying to use thread_safe_signals with Dataflow.Signals, I did the following before including the headers to cause thread_safe_signals to use the boost::signals namespace instead of boost::signalslib (I needed this because Dataflow.Signals adds to the boost::signals namespace):
Isn't putting dataflow library stuff in boost::signals wrong (as in, against boost policy)? Shouldn't your library stay out of other library's namespaces? Is there any reason socket_sender (for example) can't be in boost::dataflow::signals instead of boost::signals?
This worked for gcc on OS X, but I just found out that msvc 2005 express chokes on it (in some preprocessing file iteration loop). Is there a better solution for this?
I don't have any specific suggestions for workarounds, but FYI if thread_safe_signals ever comes up for review, my plan is to ditch the signals namespace alias which was attempting to provide some backwards compatibility. I plan to move everything into a "signals2" namespace, and rearrange the headers to conform to boost policy.