On 08/10/2006 12:21 PM, Doug Gregor wrote:
On Aug 9, 2006, at 10:04 AM, Tiago de Paula Peixoto wrote:
I've written a graphml reader/writer for BGL, based on the code Douglas Gregor posted on the boost users list at http://article.gmane.org/gmane.comp.lib.boost.user/17877/, and I'm sending it attached.
I've been busy integrating this GraphML reader into the BGL Python bindings, and I have a few comments along the way:
Cool!
- I believe the boolean type in GraphML is named "boolean", not "bool"
Yep. Thanks. ;-)
- It would be really great if we could get most of the GraphML reader code into a .cpp file, perhaps using the same tricks that we use in the GraphViz reader. Ideally, the BGL GraphML header would not include Expat at all.
I guess we can just write a mutate_graph virtual base class, and work only with that in the .cpp file, just like in the graphviz code, without any problems. I'll work on that this weekend, together with the documentation and test case.
- We should have an overload that doesn't need the vertex_index map to be passed explicitly; it can just default to get(vertex_index, g).
Yeah, ok. Thanks a lot for the comments! -- Tiago de Paula Peixoto <tiago@forked.de>