
9 Dec
2010
9 Dec
'10
8:10 p.m.
Christian Henning wrote:
There are some specific problems with the tests, though. ?For instance, png_read_test.cpp takes an image file, reads it, then writes it to a temporary file, then re-reads it from the temp file, and compares the two read-in images for equality. ?This strikes me as a bad test. ?It is quite possible to read an image, get the wrong results, then write those wrong results to disk, re-read them, and then have the re-read results compare equal to the original read results. ?There may be other tests with a similar organization; I did not check.
This would assume that both png reader and writer have some bugs in common.
No it doesn't. Imagine a bug in the reader that caused the data to be all 0. Phil.