Re: [boost] [Fit] Louis Dionne's formal review

On Saturday, March 12, 2016 3:38 PM, Louis Dionne wrote:

...

Paul Fultz II writes:

...

[...]

Thanks Louis for the review. Do you have any feedback/thoughts about the compile-time performance of the library?

It's hard to tell without doing benchmarks, which I didn't do. Things I might suggest benchmarking would be creating large `fit::pack`s and `fit::capture`s, using `compress` with many arguments and using `fit::arg` with many arguments.

Just looking at the implementation quickly, it seems OK. For example `pack` does not use a recursive implementation and all the functions I looked at used flat variadic expansion whenever possible instead of recursion. The C++11/14 way, basically. However, `detail::seq` is implemented using recursion. It's not dramatic, but you could use a logarithmic approach

instead to avoid hitting template instantiation depth limits.

Thats a good idea, I opened an issue to change this.

Regards, Louis

_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost