on Sat Dec 01 2007, Juergen Hunold <juergen.hunold-AT-ivembh.de> wrote:
Hi Dav !
On Samstag 01 Dezember 2007, David Abrahams wrote:
on Sat Dec 01 2007, Juergen Hunold <juergen.hunold-AT-ivembh.de>
Ok to commit ?
Yes please, as long as you've checked carefully to make sure that things like assert() and #ifdef don't cause those names to be needed in some other build configuration.
Done. Revisions 41544,41549,41550
I found some more unused parameters and missing virtual d'tors while doing the full test runs.
Uh, wait: missing virtual d'tors? Sorry, I should have paid more attention. That warning is bogus and I certainly don't want anyone "fixing" it if there are no other virtual functions in the class. And even if there are other virtual functions, I think it's a suspicious change to make. Please back out any added virtual dtors!
The last warning ist a BOOST_ASSERT in boost/python/converter/implicit.hpp
This could be fixed by using the new BOOST_VERIFY macro instead.
Patch attached.
Uh, no thanks. I *want* the test to compile away in release mode. See http://lists.boost.org/Archives/boost/2006/06/106919.php . I think one of these already exists somewhere in Boost.Python.
Index: boost/python/converter/implicit.hpp =================================================================== --- boost/python/converter/implicit.hpp (revision 41535) +++ boost/python/converter/implicit.hpp (working copy) @@ -32,7 +32,7 @@
arg_from_python<Source> get_source(obj); bool convertible = get_source.convertible(); - BOOST_ASSERT(convertible); + BOOST_VERIFY(convertible);
new (storage) Target(get_source());
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
-- Dave Abrahams Boost Consulting http://www.boost-consulting.com