
1 Dec
2005
1 Dec
'05
6:16 p.m.
Daryle Walker wrote:
On 11/29/05 4:27 PM, "Jason Kankiewicz" <jkankiewicz@advpubtech.com> wrote:
+# elif (defined(__GNUC__) && ((__GNUC__ >= 3 && __GNUC_MINOR__ >=5) || __GNUC__ >= 4))
Shouldn't the check for GCC 3.x be:
__GNUC__ == 3 && __GNUC_MINOR__ >= 5
instead of the currently over-broad version? Otherwise version numbers like 4.6 or 5.9 would match on that phrase, which is wrong.
I agree that your version's syntax is preferable. My only modification was to tack on "|| __GNUC__ >= 4" and the requisite enclosing parentheses in order to make the smallest change that could possibly work. Dave didn't apply my patch verbatim anyway as his fix is more elegant.