Niall wrote:
I really wish you German HPC guys would stop cherry picking and twisting my words to suit your incessant point scoring. I find it disrespectful, petty and juvenile, and I am sure so do most people here. So please stop it. If you do it again Andreas, you will see no further replies from me to anything you say, same as Hartmut.
In an attempt to divert attention away from the deteriorating relations between Ireland and Germany, I wrote: I see code like: ``` auto buffer=std::make_shared<std::unique_ptr<path::value_type[]>>(new path::value_type[buffersize]); ``` Is this really what you intended? a shared_ptr<unique_ptr<T[]> >? I would have thought you'd want shared_ptr<T[]> with one allocation instead of two. Also, I noticed (when trying to get AFIO standalone working with ASIO standalone) that you check: ``` #if ASIO_STANDALONE ``` Don't you mean #if !defined(ASIO_STANDALONE)? Most people just define ASIO_STANDALONE, not define it to a value like 1. What you have would be an error during compilation in that case. Best, Glen -- View this message in context: http://boost.2283326.n4.nabble.com/afio-Formal-review-of-Boost-AFIO-tp467911... Sent from the Boost - Dev mailing list archive at Nabble.com.