Jens Seidel wrote:
Are the last two tests OK? Two const char* pointer are compared by address!?
They are not. I misunderstood how BOOST_CHECK works. The correct fix may look like the following: #if defined(__hpux) BOOST_CHECK( ec.message() == "" ); #elif defined(__osf__) BOOST_CHECK( ec.message() == "Error -1 occurred." ); #elif defined(__vms) BOOST_CHECK( ec.message() == "error -1" ); #else BOOST_CHECK( ec.message().substr( 0, 13) == "Unknown error" ); #endif Thanks for pointing it out. Boris ----- Original Message ----- From: "Jens Seidel" <jensseidel@users.sf.net> To: <boost@lists.boost.org> Sent: Monday, November 05, 2007 3:39 PM Subject: Re: [boost] [system] error_code_test.cpp does not accountfor implementation-specific behaviour of strerror()
On Mon, Nov 05, 2007 at 02:47:15PM -0500, Boris Gubenko wrote:
Forgot VMS:
#if defined(__hpux) BOOST_CHECK( *(ec.message().c_str()) == 0 ); #elif defined(__osf__) BOOST_CHECK( ec.message().c_str() == "Error -1 occurred." ); #elif defined(__vms) BOOST_CHECK( ec.message().c_str() == "error -1" );
Are the last two tests OK? Two const char* pointer are compared by address!?
#else BOOST_CHECK( ec.message().substr( 0, 13) == "Unknown error" ); #endif
Jens _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost