John Maddock wrote:
C4512 fix looks good to me, but I also note some warnings C4244: 'argument' : conversion from 'const int' to 'const short', possible loss of data
These could be quieted with carefully checked static_cast s.
This checks and documents that the narrowing IS expected.
As long as it really is expected :-)
Looks like the warnings occur depending on the types used in the unit tests. For example, the warning mentioned above comes from the test code: /// typedef variant< short, const char* > t_var2; typedef variant< unsigned short, const char*, t_var2 > t_var5; typedef variant< unsigned short, const char*, t_var5 > t_var6; t_var6 v6; v6 = 58; /// Which looks like a legitimate warning about converting an integer (58) to a short. -- View this message in context: http://old.nabble.com/Official-warnings-policy--tp26200658p26304401.html Sent from the Boost - Dev mailing list archive at Nabble.com.