12 Aug
2019
12 Aug
'19
8:41 a.m.
Some more thoughts from a first glance at the library: In https://tzlaine.github.io/iterator_facade/doc/html/boost_iteratorfacade__pro... you list the user supplied operations. The method names should exactly correspond to the existing ones used by boost.iterator, see https://www.boost.org/doc/libs/1_71_0/libs/iterator/doc/iterator_facade.html compare vs. distance_to equals vs. equal next vs. increment prev vs. decrement The reason is that the old names were likely already "optimised" by previous reviews and you should make it easy for people to port existing code to iterator2. Switching from iterator to iterator2 should be as easy changing the included header for simple cases. Best regards, Hans