24 Jun
2012
24 Jun
'12
10:04 p.m.
Thank you for your review, Keith.
1) Introduction : I would prefer to see e.g. mp::int128_t rather than mp::mp_int128_t, given the stated purpose of the library.
Yes, the consensus seems to be that the additional "mp_" part of the class names is redundant. 2) cpp_dec_float : Narrowing conversions are truncating. This is a no-no for the usage I have in mind at the moment. Yes, almost all reviewers requested rounding as an improvement over truncation. This is one of my parts of the library, so i might need to work on it and maybe seek help from others, since I don't know a clever way to round radix-10 to radix-2. <snip> Best regards, Chris.