C4512 fix looks good to me, but I also note some warnings C4244: 'argument' : conversion from 'const int' to 'const short', possible loss of data
These could be quieted with carefully checked static_cast s.
This checks and documents that the narrowing IS expected.
As long as it really is expected :-) I haven't looked though, so I don't know anything about this case.
In the jamfile you can suppress the C4535 calling _set_se_translator() requires /EHa with
project : requirements ...
adding
<toolset>msvc:<asynch-exceptions>on # calling _set_se_translator() requires /EHa
It would be better if Boost.Test did this?
Nod. Not sure if it can in this case, since Variant doesn't actually link to the Boost.Test binaries.
boost\boostsvn\boost\test\impl\execution_monitor.ipp(1161) : warning C4701: potentially uninitialized local variable 'old_crt_hook' used
looks dodgy in Boost.Test too? Trak tickets?
I've already filed a patch against Boost.Test for this and other issues: https://svn.boost.org/trac/boost/ticket/3598 John.