On Thu, Aug 22, 2019 at 10:14 PM Gavin Lambert via Boost < boost@lists.boost.org> wrote:
On 23/08/2019 14:11, Zach Laine wrote:
Online docs:
https://tzlaine.github.io/stl_inteTherfaces/doc/html/index.html <https://tzlaine.github.io/stl_interfaces/doc/html/index.html>
Speaking of iterators being error-prone (and the ironic typo in the above link):
How'd that get in there? That's weird.
In
https://tzlaine.github.io/stl_interfaces/doc/html/boost_stlinterfaces__propo... the long-form implementation of repeated_chars_iterator::operator>= is not correct.
Thanks. I almost want to leave it for pedagogical reasons.
And operator-(difference_type lhs, repeated_chars_iterator rhs) seems dubious; this operation is normally not commutative. It seems more correct for that operator to not exist.
Yeah, that should not be there.
(And I hope that iterator_interface does not define it either.)
It does not.
There's also several typos sprinkled around, such as "givenn" and using "if" instead of "it", etc.
I just ran a spell-check on the docs. I think I got all the typos. I did not notice the if/it confusion. Where was that?
I haven't read this in detail yet, but it sounds interesting.
Are you planning to add support for AllocatorAwareContainer at a later stage, or is there something that would make that infeasible?
I hate allocators. I will not be adding support for allocator-aware containers. Thanks for the feedback. Does this mean that you'd like to see a review? Zach