14 May
2015
14 May
'15
12:52 p.m.
AMDG On 05/13/2015 08:51 PM, Marshall Clow wrote:
On Mon, May 4, 2015 at 7:43 AM, Maarten de Vries <maarten@de-vri.es> wrote:
[snip]
If my assumption was correct, pull request here: https://github.com/boostorg/variant/pull/15
I see that this has been addressed, but I noticed that your pull request was for merging into the "master" branch.
That's a non-starter; pull requests should always go into "develop", and then after the tests cycle, they can be merged to "master"
Personally, while I prefer pull requests to be against develop, I always manually merge and rebase them anyway. I don't think people should have to know the details of our processes to submit pull requests. In Christ, Steven Watanabe