- Boost - lists.preview.boost.org

Re: [boost] [Scope] Peer review conclusion
by Andrey Semashev 06 Feb '24

06 Feb '24

On 2/6/24 22:29, Дмитрий Архипов wrote: > Looks good to me. I consider the review conditions satisfied. Thank you Dmitry. And especially for taking the time to review the documentation and point out errors. > пн, 5 февр. 2024 г. в 03:47, Andrey Semashev <andrey.semashev(a)gmail.com>: > >> >> On 1/15/24 22:50, Дмитрий Архипов via Boost wrote: >>> Dear Boost community, the formal review of Boost.Scope has taken place >>> between 26th of November and 5th of December of the previous year. I >>> have received 5 reviews in total, including 4 here on the mailing list >>> and 1 on Reddit. Two of the reviews recommended unconditional, and 3 >>> conditional acceptance. The >>> reviews came from: >>> - Klemens Morgenstern, >>> - Janko Dedic, >>> - Julien Blanc, >>> - David Sankel, >>> - /u/jonesmz on Reddit. >>> >>> Also, several people have given insightful comments but did not provide a >>> review. I would like to thank all of the people who took their time to write >>> reviews or participate in the discussions. Your effort was very important and >>> valuable. >>> >>> The outcome of the review is that Boost.Scope is ACCEPTED with several minor >>> CONDITIONS. >>> >>> 1. noexcept specification on destructors of scope guards should be properly >>> documented. Andrey has already commented that the technical hurdle that >>> prevented it was eliminated. >>> >>> 2. There should be a good motivating example for scope_success. There was a lot >>> of comments regarding scope_success and its seeming uselessness. Without a >>> good example I see the same pattern occurring with future users. >>> >>> 3. The examples should better describe what they are trying to achieve. Several >>> comments about examples suggested incorrect changes, which signals that readers >>> failed to understand them. >>> >>> After a lot of consideration I decided against requesting the author to remove >>> unique_resource and related functionality from the library. While several >>> reviewers wanted a more "concise" library, all noted that the component is >>> useful. >>> >>> One last thing I wanted to point out is that all reviewers and most commenters >>> were adamant that compatibility with the Technical Specification on which this >>> library was initially based should not be a goal. In fact, Andrzej Krzemienski >>> even noted that such compatibility has prevented him from adequately evaluating >>> the library on its own merit. In my opinion this should be a sign to all of us >>> that people prefer better APIs over standard APIs. I recommend Andrey to >>> re-evaluate those parts of the library's APIs that he copied from the TS and >>> potentially pick better names for member functions. >>> >>> Thanks to Andrey for submitting this library to Boost. And thanks again to the >>> reviewers and everyone who provided feedback, who ultimately made this review >>> possible. >> >> I have updated the library according to review comments and conditions. >> To specifically address the acceptance conditions: >> >> 1. Noexcept specifications for destructors are now present in the docs. >> For example: >> >> https://lastique.github.io/scope/libs/scope/doc/html/boost/scope/defer_guar… >> https://lastique.github.io/scope/libs/scope/doc/html/boost/scope/scope_exit… >> https://lastique.github.io/scope/libs/scope/doc/html/boost/scope/unique_res… >> >> The fix for the BoostBook stylesheets is currently in develop. >> Hopefully, it will get merged to master soon. >> >> 2. I have added an example showing usage of all three conditional scope >> guards, including scope_success, here: >> >> https://lastique.github.io/scope/libs/scope/doc/html/scope/scope_guards.htm… >> >> The example is based on the one I posted during the review. >> >> 3. I have added more comments to some examples, as well as the >> discussion around them. For example, the examples on the front page are >> better commented now: >> >> https://lastique.github.io/scope/libs/scope/doc/html/index.html >> >> Some examples were modified or completely rewritten. For example, the >> locked_write_string was modified to reduce code duplication: >> >> https://lastique.github.io/scope/libs/scope/doc/html/index.html >> >> The leading example for unique_resource was rewritten: >> >> https://lastique.github.io/scope/libs/scope/doc/html/scope/unique_resource.… >> >> And a new example for unique_resource was added on the front page: >> >> https://lastique.github.io/scope/libs/scope/doc/html/index.html >> >> There are many more additions and modifications than I can mention here. >> >> >> There were also changes that were requested by reviewers or were the >> result of the discussion. The changelog here lists most of the changes: >> >> https://lastique.github.io/scope/libs/scope/doc/html/scope/changelog.html >> >> To mention the most prominent changes: >> >> * BOOST_SCOPE_FINAL was renamed to BOOST_SCOPE_DEFER and scope_final to >> defer_guard. >> * The `release()` member of scope guards was removed. `set_active()` is >> still present and is the way to activate and deactivate scope guards. >> * Added `operator bool()` to `unique_resource`. >> * Added a C++17 `unallocated_resource` class template that simplifies >> declaration of resource traits when all unallocated resource values can >> be listed. Along with the recently added to Boost.Core `functor` >> template, this can significantly reduce the amount of code one needs to >> write to declare a `unique_resource`. For example, a `unique_resource` >> for Windows handles could be declared like this: >> >> unique_resource< >> HANDLE, >> functor< CloseHandle >, >> unallocated_resource< INVALID_HANDLE_VALUE, (HANDLE)NULL > >> > handle; >> >> https://lastique.github.io/scope/libs/scope/doc/html/scope/unique_resource.… >> https://www.boost.org/doc/libs/develop/libs/core/doc/html/core/functor.html >> >> * `unique_resource` now enforces requirements on the resource traits >> with static asserts rather than falling back to the "no resource traits" >> mode of operation. >> * `unique_resource` no longer supports the "reduced" resource traits, >> where the traits were only used to customize the default resource value >> but not to distinguish allocated and unallocated resource values. >> * Added documentation sections discussing differences with the Library >> Fundamentals TS: >> >> https://lastique.github.io/scope/libs/scope/doc/html/scope/scope_guards.htm… >> https://lastique.github.io/scope/libs/scope/doc/html/scope/unique_resource.… >> >> * On the front page, removed comparison with Boost.ScopeExit from the >> table. There is a separate section for it: >> >> https://lastique.github.io/scope/libs/scope/doc/html/scope/scope_guards.htm… >> >> Also added another row to the table that shows explicit deactivation of >> the scope guards by calling `set_active(false)`. >> >> * There is now a section discussing caveats of capturing variables by >> reference in scope guards: >> >> https://lastique.github.io/scope/libs/scope/doc/html/scope/scope_guards.htm… >> >> There are probably other changes that I forgot to mention. >> >> >> Dmitry, please let me know if you consider the review conditions >> satisfied or if there needs to be done something more. >> >> If everything's fine, what needs to be done to move the library into >> boostorg? >>

1 0

Re: [boost] critical bugs in charconv
by g.peterhoff＠t-online.de 05 Feb '24

05 Feb '24

> So what's your point? Another example. I had asked for a TypeTrait is_integer and also supplied code for it (https://github.com/boostorg/type_traits/issues/186) The point is that is_integer only returns integer (no character, no bool). John immediately closed my request "We are not responsible for that". Instead of admitting a mistake (of course I make some myself) and saying "we forgot/didn't think of it, we'll do it", the only answer is "we don't care". That's thinking from the wallpaper to the wall. As I said, boost used to be progressive, but now when you make a suggestion, all you get is "We're not responsible for that/we're not interested in that/we might have to change something that's not possible" And this even with such a simple TypeTrait. Single file. No dependencies. And on the other hand, libraries with the most severe buffer overflows (charchonv) are included, where obviously no tests are carried out at all.

5 5

Re: [boost] critical bugs in charconv
by g.peterhoff＠t-online.de 05 Feb '24

05 Feb '24

> So what's your point? a) boost/math/policies/error_handling.hpp manual name_of, although it would be no problem to add a simple nameof in boost/core/demagle.hpp: template <typename Type> inline std::string nameof() { return demangle(typeid(Type).name()); } b) boost/math/policies/policity.hpp manual "variadic templates" c) boost.convert (apart from the fact that this library is unusable due to its design) - no C++23 FP types - no (unsigned)__int128 - no __float128 These are just the things that came to my mind. The whole design and supported types of boost is stuck 25 years ago. As I said, I'm grateful that boost made C++11 possible. But since then you are stuck at this level and changes are *not* welcome.

2 1

critical bugs in charconv
by g.peterhoff＠t-online.de 05 Feb '24

05 Feb '24

Hello Matt, Sorry for submitting a bug report this way. (Having problems with my GitHub account at the moment). Code: Attachment (gcc 13.2 -std=gnu++23 -O3 -Wall -fanalyzer) Errors (normal) - Missing sign - Hex exponent is wrong - Hex is completely wrong - Accuracy is not correct - Error code deviates from the standard ... The backup functions via (quadmath)snprintf do not work. Errors (critical) - If the buffer is too small (e.g. set the array size to 3) there are a lot of buffer overflows. Especially with value ±nan/±inf. The functions should therefore always be structured in the same way: Auxiliary function inline constexpr bool is_valid_range(const char*const first, const char*const last) noexcept { return (first!=nullptr && last!=nullptr) ? first < last : false; } Pseudocode to_chars(...) // FP { to_chars_result result{last, std::errc::value_too_large}; if (is_valid_range(first, last)) [[likely]] { const size_t size = size_t(last - first); if (inf or nan) [[unlikely]] { if (size is large enough) { copy the string values into the range result = ...; Here you could also use #define to specify whether the string values are compatible with the standard or not. "±inf", "±nan" or https://develop.charconv.cpp.al/#to_chars_usage_notes_for_to_chars_for_floa… } } else { convert, detail::implemantation(first, size, ...) result = ...; } } return result; } to_chars(...) // INT { to_chars_result result{last, std::errc::value_too_large}; if (is_valid_range(first, last)) [[likely]] { const size_t size = size_t(last - first); convert, detail::implemantation(first, size, ...) result = ...; } return result; } This can be achieved with templates and typetraits: FP boost::is_floating_point still does not contain any C++23 types. template <typename Type> BOOST_NOINLINE typename std::enable_if<std::is_floating_point<Type>::value, to_chars_result>::type to_chars(char*const first, char*const last, const Type value, const chars_format format, const int precision) noexcept; template <type name Type> BOOST_NOINLINE typename std::enable_if<std::is_floating_point<Type>::value, to_chars_result>::type to_chars(char*const first, char*const last, const Type value, const chars_format format) noexcept; INT (boost)is_integer is unfortunately still missing. template <type name Type> BOOST_NOINLINE typename std::enable_if<boost::is_integer<Type>::value, to_chars_result>::type to_chars(char*const first, char*const last, const Type value, const int base = 10) noexcept; regards Gero

4 5

[Scope] Peer review conclusion
by Дмитрий Архипов 05 Feb '24

05 Feb '24

Dear Boost community, the formal review of Boost.Scope has taken place between 26th of November and 5th of December of the previous year. I have received 5 reviews in total, including 4 here on the mailing list and 1 on Reddit. Two of the reviews recommended unconditional, and 3 conditional acceptance. The reviews came from: - Klemens Morgenstern, - Janko Dedic, - Julien Blanc, - David Sankel, - /u/jonesmz on Reddit. Also, several people have given insightful comments but did not provide a review. I would like to thank all of the people who took their time to write reviews or participate in the discussions. Your effort was very important and valuable. The outcome of the review is that Boost.Scope is ACCEPTED with several minor CONDITIONS. 1. noexcept specification on destructors of scope guards should be properly documented. Andrey has already commented that the technical hurdle that prevented it was eliminated. 2. There should be a good motivating example for scope_success. There was a lot of comments regarding scope_success and its seeming uselessness. Without a good example I see the same pattern occurring with future users. 3. The examples should better describe what they are trying to achieve. Several comments about examples suggested incorrect changes, which signals that readers failed to understand them. After a lot of consideration I decided against requesting the author to remove unique_resource and related functionality from the library. While several reviewers wanted a more "concise" library, all noted that the component is useful. One last thing I wanted to point out is that all reviewers and most commenters were adamant that compatibility with the Technical Specification on which this library was initially based should not be a goal. In fact, Andrzej Krzemienski even noted that such compatibility has prevented him from adequately evaluating the library on its own merit. In my opinion this should be a sign to all of us that people prefer better APIs over standard APIs. I recommend Andrey to re-evaluate those parts of the library's APIs that he copied from the TS and potentially pick better names for member functions. Thanks to Andrey for submitting this library to Boost. And thanks again to the reviewers and everyone who provided feedback, who ultimately made this review possible.

3 5

[charconv] Review Results and Report
by Christopher Kormanyos 02 Feb '24

02 Feb '24

Dear Boost Community, The review of the proposed Boost.Charconv is finished It took place 15-25 January 2024. REVIEW RESULT ----------------------------- The result is Boost.Charconv is unconditionally * ACCEPTED * into Boost. Thank you Matt. Boost.Charconv will enrich Boost and surely be used vigorously. REVIEW REPORT ----------------------------- The review tally is: * 1 Conditional ACCEPT * 4 ACCEPT * 1 Positive Document Review ---------------------------- = 5 ACCEPT, since the single condition has already been satisfied in develop branch. My Comments and Descriptions below are based on limited knowledge and my subjective interpretations. Please correct, add, modify these (and to these) as needed. * Comments: The review atmosphere was highly productive and excellent. Reviews and contributions featured deep technical content and detail. Fact-based statements combined with experienced-based opinions were provided. There was great strength of expression and clarity. Yet there was mutual respect and fairness, even in the course of lively debate. * Descriptions: Ultimately there were three areas receiving the most debate. For background, see references below. 1) The library needs to allocate. Among other conversions, Boost.Charconv handles conversion of floating-point values to chars. Edge-cases may require hundreds or even thousands of bits. * Consensus: Handle the required memory needed, as done, with low-level C-LIB malloc. But do describe this decision with greater depth of clarity in the docs. 2) The project makes use of a variety of methods, including some table-driven methods. One example is RYU (see [1]). A quick glance at Fig. 4 in [1], for instance, reveals the need for relatively large, constant-valued tables. Largescale tables, combined with the C++11 design goal formed a clear indication to produce a compiled library (as opposed to a header-only one). * Consensus: Compiled-library is sound and viable. Tables (especially in constexpr-context) might bloat or not even work in some language-standards environments. Some commenters, however, seemed subjectively to disapprove of this consensus, feeling that header-only offers the best chances at friction-free setup and convenient portability. Other commenters revealed a sense that compiled libraries are gaining traction in the industry. They feel that this is because the community, their available tools, language-skills, specifications, compilers, CI, VMs, etc. have matured significantly and continue to mature. Thereby they embrace a perceived future-oriented trend that views client-builds to be uncomplicated. There were no blockers on the consensus. 3) The top-level interface differs from that of std-<charconv> in points such as overloads and error-handling. Whereas some details are not even fully hashed-out in the Standard. * Consensus: Weigh known opinions and decide interface details based on unbiased majority. My current understanding is: Offer two drop-ins for from_chars, with the caveat that one should provide better error-handling. REVIEW ACKNOWLEDGMENTS ----------------------------- Thanks again, Matt for Boost.Charconv. Many thanks to our expert reviewers, commenters and watchers. Your contributions keep Boost excellent! Kindest regards, Christopher Kormanyos Boost.Charconv Review Manager * References: [1] Ulf Adams, "RYU: fast float-to-string conversion", ACM SIGPLAN Notices, Volume 53, Issue 4, pp 270–282 (ACM 2018) [2] "Number Parsing at a Gigabyte per Second", Daniel Lemire's Blog, https://lemire.me/blog/2021/01/29/number-parsing-at-a-gigabyte-per-second/ [3] https://github.com/lemire/fast_double_parser

1 0

[charconv] Review Results and Report
by Christopher Kormanyos 02 Feb '24

02 Feb '24

Dear Boost Community, The review of the proposed Boost.Charconv is finished It took place 15-25 January 2024. REVIEW RESULT ----------------------------- The result is Boost.Charconv is unconditionally * ACCEPTED * into Boost. Thank you Matt. Boost.Charconv will enrich Boost and surely be used vigorously. REVIEW REPORT ----------------------------- The review tally is: * 1 Conditional ACCEPT * 4 ACCEPT * 1 Positive Document Review ---------------------------- = 5 ACCEPT, since the single condition has already been satisfied in develop branch. My Comments and Descriptions below are based on limited knowledge and my subjective interpretations. Please correct, add, modify these (and to these) as needed. * Comments: The review atmosphere was highly productive and excellent. Reviews and contributions featured deep technical content and detail. Fact-based statements combined with experienced-based opinions were provided. There was great strength of expression and clarity. Yet there was mutual respect and fairness, even in the course of lively debate. * Descriptions: Ultimately there were three areas receiving the most debate. For background, see references below. 1) The library needs to allocate. Among other conversions, Boost.Charconv handles conversion of floating-point values to chars. Edge-cases may require hundreds or even thousands of bits. * Consensus: Handle the required memory needed, as done, with low-level C-LIB malloc. But do describe this decision with greater depth of clarity in the docs. 2) The project makes use of a variety of methods, including some table-driven methods. One example is RYU (see [1]). A quick glance at Fig. 4 in [1], for instance, reveals the need for relatively large, constant-valued tables. Largescale tables, combined with the C++11 design goal formed a clear indication to produce a compiled library (as opposed to a header-only one). * Consensus: Compiled-library is sound and viable. Tables (especially in constexpr-context) might bloat or not even work in some language-standards environments. Some commenters, however, seemed subjectively to disapprove of this consensus, feeling that header-only offers the best chances at friction-free setup and convenient portability. Other commenters revealed a sense that compiled libraries are gaining traction in the industry. They feel that this is because the community, their available tools, language-skills, specifications, compilers, CI, VMs, etc. have matured significantly and continue to mature. Thereby they embrace a perceived future-oriented trend that views client-builds to be uncomplicated. There were no blockers on the consensus. 3) The top-level interface differs from that of std-<charconv> in points such as overloads and error-handling. Whereas some details are not even fully hashed-out in the Standard. * Consensus: Weigh known opinions and decide interface details based on unbiased majority. My current understanding is: Offer two drop-ins for from_chars, with the caveat that one should provide better error-handling. REVIEW ACKNOWLEDGMENTS ----------------------------- Thanks again, Matt for Boost.Charconv. Many thanks to our expert reviewers, commenters and watchers. Your contributions keep Boost excellent! Kindest regards, Christopher Kormanyos Boost.Charconv Review Manager * References: [1] Ulf Adams, "RYU: fast float-to-string conversion", ACM SIGPLAN Notices, Volume 53, Issue 4, pp 270–282 (ACM 2018) [2] "Number Parsing at a Gigabyte per Second", Daniel Lemire's Blog, https://lemire.me/blog/2021/01/29/number-parsing-at-a-gigabyte-per-second/ [3] https://github.com/lemire/fast_double_parser

1 0

Using ASIO to wait on a foreign socket being readable, with a timeout
by Dominique Devienne 31 Jan '24

31 Jan '24

Hi, I'm trying to use ASIO to wait until a socket is ready to read, or timeout. This is a blocking wait. But the socket is not "owned" by ASIO, but is from the libpq PostgreSQL connection. So ASIO should NOT consume any of the input on the socket, just notify me when that socket is "read-ready". I've cobbled together the following test code: ``` const int socket2 = PQsocket(conn2.handle()); BOOST_CHECK(socket2 > 0); int timr_err_code = 0; int sock_err_code = 0; bool timr_aborted = false; bool sock_aborted = false; std::string timr_err_msg; std::string sock_err_msg; bool timed_out = true; auto c1 = "C# 1"sv; conn2.listen(c1); conn1->notify(c1, "wake up!"sv); { boost::asio::io_context io_ctx; boost::asio::ip::tcp::socket io_sock(io_ctx); io_sock.assign(boost::asio::ip::tcp::v4(), socket2); boost::asio::steady_timer io_timer(io_ctx); io_timer.expires_from_now(std::chrono::milliseconds(100)); io_sock.async_wait( io_sock.wait_read, [&](const boost::system::error_code& errc) { if (errc) { sock_err_code = errc.value(); sock_err_msg = errc.message(); sock_aborted = (errc == boost::asio::error::operation_aborted); } timed_out = false; //io_timer.cancel(); io_ctx.stop(); } ); io_timer.async_wait( [&](const boost::system::error_code& errc) { if (errc) { timr_err_code = errc.value(); timr_err_msg = errc.message(); timr_aborted = (errc == boost::asio::error::operation_aborted); } io_sock.cancel(); io_ctx.stop(); } ); io_ctx.run(); // blocks until either async op above runs } // there's a notif to read, so io_sock.async_wait should have completed BOOST_CHECK_EQUAL(timr_err_code, 0); BOOST_CHECK_EQUAL(sock_err_code, 0); BOOST_CHECK_EQUAL(timr_err_msg, ""); BOOST_CHECK_EQUAL(sock_err_msg, ""); BOOST_CHECK_EQUAL(timr_aborted, false); BOOST_CHECK_EQUAL(sock_aborted, false); BOOST_CHECK_EQUAL(timed_out, false); auto notif = conn2.notification(); BOOST_REQUIRE(notif); BOOST_CHECK_EQUAL(notif.backend_pid(), pid1); BOOST_CHECK_EQUAL(notif.channel(), c1); BOOST_CHECK_EQUAL(notif.payload(), "wake up!"sv); ``` The io_sock.async_wait(io_sock.wait_read, ...) succeeds, the IO loop stops as expected, but when I try to PQconsumeInput() from the LIBPQ connection next (as shown in the code below) ``` Notification Connection::notification() { auto [lock, hndl] = ensure_handle(); if (1 != PQconsumeInput(hndl)) { throw std::runtime_error(error_msg()); // <<<<<< THROWS } PGnotify_uptr notif{ PQnotifies(hndl) }; return Notification(std::move(notif)); // may be null } ``` that calls fail with this error message: fatal error: in "NotificationTests/test_across_backends": class std::runtime_error: could not receive data from server: Socket operation on non-socket (0x00002736/10038) LIBPQ didn't like what ASIO somehow did on the socket descriptor. The LIBPQ doc says to select() the descriptor, but I thought ASIO would be cleaner, more C++, and perhaps more cross-platform. Can somehow help, telling me if I'm using ASIO incorrectly here? Thanks, --DD

3 2

Boost.Charconv review runs January 15th - 25th, 2024
by Christopher Kormanyos 31 Jan '24

31 Jan '24

Dear all, The review of Boost.Charconv by Matt Borland runs Monday, January 15th through January 25th, 2024. Code: https://github.com/cppalliance/charconvDocs: https://master.charconv.cpp.al/Review Schedule: https://www.boost.org/community/review_schedule.html Thank you for considering this review. Please optionally provide feedback on the followinggeneral topics: - What is your evaluation of the design? - What is your evaluation of the implementation? - What is your evaluation of the documentation? - What is your evaluation of the potential usefulness of the library? - Did you try to use the library? With what compiler? Did you have any problems? - How much effort did you put into your evaluation? A glance? A quick reading? In-depth study? - Are you knowledgeable about the problem domain? Christopher KormanyosBoost.Charconv Review Manager

15 76

[charconv] is std::from_chars practical?
by Andrzej Krzemienski 26 Jan '24

26 Jan '24

Hi Everyone, This is about https://github.com/cppalliance/charconv/issues/110, again. Now I understand Peter's point better. std::from_chars is impractical, or one would say "broken", at least for the case of ERANGE. Actually applying a patch in https://cplusplus.github.io/LWG/lwg-active.html#3081 will not make the tool good, it will just make it broken in another way. In that case, maybe the goal of providing literally a *drop-in replacement* for std::from_chars is not a good one? Maybe this is the case similar to variant2, where the community would benefit more from the library motivated by "how would from_chars look like if we designed it instead of WG21". That is, an *alternative to* std::from_chars, rather than a *drop-in-replacement for* std::from_chars. Regards, &rzej;

6 6