October 2004 - Boost - lists.preview.boost.org

boost::threads' exceptions patch
by Rodolfo Schulz de Lima 03 Oct '04

03 Oct '04

Hi, I've been using boost::threads for some time now and found it to be very useful and elegant in design. The only problem I see is when it throws an exception. No information about the error is fed to the exception constructor, and all we have is a 'boost::thread_resource_error' or a 'boost::lock_error' in std::exception::what, not very helpful. Since boost::thread_exception has a constructor that accepts an error code, I've managed to patch some files and fed (where appropriate) the error code to the exception constructor so that we can have an idea of what is the cause of the exception when we catch it. Not being fully satisfied with the results (we never are), I went a little further and decided to make thread_exception inherit from std::runtime_error, and pass to its constructor an informative message about the exception. This way std::exception::what will show not only the exception class name, but also the reason of the error (if we have an error core). I've modified the other exception classes accordingly. The last thing I did was to remove thread_argument_error since we could use std::argument_error instead. In fact, this class is never used, and in the only place that it would be used, std::argument_error is used. I'd appreciate any comments about those changes... Regards, rod IMPORTANT NOTE: I've just changed the PTHREADS implementation... I do not have good background on winthreads and mptasks, so I count on anyone who knows those systems to update their implementation... // Patch follows Index: boost/thread/exceptions.hpp =================================================================== RCS file: /cvsroot/boost/boost/boost/thread/exceptions.hpp,v retrieving revision 1.14 diff -u -r1.14 exceptions.hpp --- boost/thread/exceptions.hpp 8 Sep 2004 15:57:03 -0000 1.14 +++ boost/thread/exceptions.hpp 2 Oct 2004 23:51:50 -0000 @@ -25,11 +25,11 @@ namespace boost { -class BOOST_THREAD_DECL thread_exception : public std::exception +class BOOST_THREAD_DECL thread_exception : public std::runtime_error { protected: thread_exception(); - thread_exception(int sys_err_code); + thread_exception(std::string message, int sys_err_code=0); public: ~thread_exception() throw(); @@ -48,8 +48,6 @@ lock_error(); lock_error(int sys_err_code); ~lock_error() throw(); - - virtual const char* what() const throw(); }; class BOOST_THREAD_DECL thread_resource_error : public thread_exception @@ -58,8 +56,6 @@ thread_resource_error(); thread_resource_error(int sys_err_code); ~thread_resource_error() throw(); - - virtual const char* what() const throw(); }; class BOOST_THREAD_DECL unsupported_thread_option : public thread_exception @@ -68,18 +64,6 @@ unsupported_thread_option(); unsupported_thread_option(int sys_err_code); ~unsupported_thread_option() throw(); - - virtual const char* what() const throw(); -}; - -class BOOST_THREAD_DECL invalid_thread_argument : public thread_exception -{ -public: - invalid_thread_argument(); - invalid_thread_argument(int sys_err_code); - ~invalid_thread_argument() throw(); - - virtual const char* what() const throw(); }; class BOOST_THREAD_DECL thread_permission_error : public thread_exception @@ -88,8 +72,6 @@ thread_permission_error(); thread_permission_error(int sys_err_code); ~thread_permission_error() throw(); - - virtual const char* what() const throw(); }; } // namespace boost Index: libs/thread/src/condition.cpp =================================================================== RCS file: /cvsroot/boost/boost/libs/thread/src/condition.cpp,v retrieving revision 1.20 diff -u -r1.20 condition.cpp --- libs/thread/src/condition.cpp 17 Jul 2004 04:33:59 -0000 1.20 +++ libs/thread/src/condition.cpp 2 Oct 2004 23:51:58 -0000 @@ -340,7 +340,7 @@ int res = 0; res = pthread_cond_init(&m_condition, 0); if (res != 0) - throw thread_resource_error(); + throw thread_resource_error(res); } condition_impl::~condition_impl() Index: libs/thread/src/exceptions.cpp =================================================================== RCS file: /cvsroot/boost/boost/libs/thread/src/exceptions.cpp,v retrieving revision 1.10 diff -u -r1.10 exceptions.cpp --- libs/thread/src/exceptions.cpp 8 Sep 2004 15:56:33 -0000 1.10 +++ libs/thread/src/exceptions.cpp 2 Oct 2004 23:51:58 -0000 @@ -69,12 +69,15 @@ namespace boost { thread_exception::thread_exception() - : m_sys_err(0) + : runtime_error("boost;:thread_exception") + , m_sys_err(0) { } -thread_exception::thread_exception(int sys_err_code) - : m_sys_err(sys_err_code) +thread_exception::thread_exception(std::string message, int sys_err_code) + : std::runtime_error(message+(sys_err_code==0 + ? "" : (": "+system_message(m_sys_err)).c_str())) + , m_sys_err(sys_err_code) { } @@ -89,17 +92,16 @@ const char* thread_exception::message() const { - if (m_sys_err != 0) - return system_message(m_sys_err).c_str(); return what(); } lock_error::lock_error() + : thread_exception("boost::lock_error") { } lock_error::lock_error(int sys_err_code) - : thread_exception(sys_err_code) + : thread_exception("boost::lock_error",sys_err_code) { } @@ -107,17 +109,13 @@ { } -const char* lock_error::what() const throw() -{ - return "boost::lock_error"; -} - -thread_resource_error::thread_resource_error() +thread_resource_error::thread_resource_error() + : thread_exception("boost::thread_resource_error") { } thread_resource_error::thread_resource_error(int sys_err_code) - : thread_exception(sys_err_code) + : thread_exception("boost::thread_resource_error",sys_err_code) { } @@ -125,17 +123,13 @@ { } -const char* thread_resource_error::what() const throw() -{ - return "boost::thread_resource_error"; -} - unsupported_thread_option::unsupported_thread_option() + : thread_exception("boost::unsupported_thread_option") { } unsupported_thread_option::unsupported_thread_option(int sys_err_code) - : thread_exception(sys_err_code) + : thread_exception("boost::unsupported_thread_option",sys_err_code) { } @@ -143,35 +137,13 @@ { } -const char* unsupported_thread_option::what() const throw() -{ - return "boost::unsupported_thread_option"; -} - -invalid_thread_argument::invalid_thread_argument() -{ -} - -invalid_thread_argument::invalid_thread_argument(int sys_err_code) - : thread_exception(sys_err_code) -{ -} - -invalid_thread_argument::~invalid_thread_argument() throw() -{ -} - -const char* invalid_thread_argument::what() const throw() -{ - return "boost::invalid_thread_argument"; -} - thread_permission_error::thread_permission_error() + : thread_exception("boost::thread_permission_error") { } thread_permission_error::thread_permission_error(int sys_err_code) - : thread_exception(sys_err_code) + : thread_exception("boost::thread_permission_error",sys_err_code) { } @@ -179,9 +151,4 @@ { } -const char* thread_permission_error::what() const throw() -{ - return "boost::thread_permission_error"; -} - } // namespace boost Index: libs/thread/src/mutex.cpp =================================================================== RCS file: /cvsroot/boost/boost/libs/thread/src/mutex.cpp,v retrieving revision 1.19 diff -u -r1.19 mutex.cpp --- libs/thread/src/mutex.cpp 29 Jul 2004 14:25:30 -0000 1.19 +++ libs/thread/src/mutex.cpp 2 Oct 2004 23:51:58 -0000 @@ -201,7 +201,7 @@ int res = 0; res = pthread_mutex_init(&m_mutex, 0); if (res != 0) - throw thread_resource_error(); + throw thread_resource_error(res); } mutex::~mutex() @@ -215,7 +215,7 @@ { int res = 0; res = pthread_mutex_lock(&m_mutex); - if (res == EDEADLK) throw lock_error(); + if (res == EDEADLK) throw lock_error(res); assert(res == 0); } @@ -223,7 +223,7 @@ { int res = 0; res = pthread_mutex_unlock(&m_mutex); - if (res == EPERM) throw lock_error(); + if (res == EPERM) throw lock_error(res); assert(res == 0); } @@ -241,7 +241,7 @@ int res = 0; res = pthread_mutex_init(&m_mutex, 0); if (res != 0) - throw thread_resource_error(); + throw thread_resource_error(res); } try_mutex::~try_mutex() @@ -255,7 +255,7 @@ { int res = 0; res = pthread_mutex_lock(&m_mutex); - if (res == EDEADLK) throw lock_error(); + if (res == EDEADLK) throw lock_error(res); assert(res == 0); } @@ -263,7 +263,7 @@ { int res = 0; res = pthread_mutex_trylock(&m_mutex); - if (res == EDEADLK) throw lock_error(); + if (res == EDEADLK) throw lock_error(res); assert(res == 0 || res == EBUSY); return res == 0; } @@ -272,7 +272,7 @@ { int res = 0; res = pthread_mutex_unlock(&m_mutex); - if (res == EPERM) throw lock_error(); + if (res == EPERM) throw lock_error(res); assert(res == 0); } @@ -291,13 +291,13 @@ int res = 0; res = pthread_mutex_init(&m_mutex, 0); if (res != 0) - throw thread_resource_error(); + throw thread_resource_error(res); res = pthread_cond_init(&m_condition, 0); if (res != 0) { pthread_mutex_destroy(&m_mutex); - throw thread_resource_error(); + throw thread_resource_error(res); } } Index: libs/thread/src/recursive_mutex.cpp =================================================================== RCS file: /cvsroot/boost/boost/libs/thread/src/recursive_mutex.cpp,v retrieving revision 1.22 diff -u -r1.22 recursive_mutex.cpp --- libs/thread/src/recursive_mutex.cpp 16 Sep 2004 17:49:16 -0000 1.22 +++ libs/thread/src/recursive_mutex.cpp 2 Oct 2004 23:52:00 -0000 @@ -300,14 +300,14 @@ assert(res == 0); } if (res != 0) - throw thread_resource_error(); + throw thread_resource_error(res); # if !defined(BOOST_HAS_PTHREAD_MUTEXATTR_SETTYPE) res = pthread_cond_init(&m_unlocked, 0); if (res != 0) { pthread_mutex_destroy(&m_mutex); - throw thread_resource_error(); + throw thread_resource_error(res); } # endif } @@ -377,7 +377,7 @@ { res = pthread_mutex_unlock(&m_mutex); assert(res == 0); - throw lock_error(); + throw lock_error(res); } if (--m_count == 0) @@ -456,14 +456,14 @@ assert(res == 0); } if (res != 0) - throw thread_resource_error(); + throw thread_resource_error(res); # if !defined(BOOST_HAS_PTHREAD_MUTEXATTR_SETTYPE) res = pthread_cond_init(&m_unlocked, 0); if (res != 0) { pthread_mutex_destroy(&m_mutex); - throw thread_resource_error(); + throw thread_resource_error(res); } # endif } @@ -577,7 +577,7 @@ { res = pthread_mutex_unlock(&m_mutex); assert(res == 0); - throw lock_error(); + throw lock_error(res); } if (--m_count == 0) @@ -641,13 +641,13 @@ int res = 0; res = pthread_mutex_init(&m_mutex, 0); if (res != 0) - throw thread_resource_error(); + throw thread_resource_error(res); res = pthread_cond_init(&m_unlocked, 0); if (res != 0) { pthread_mutex_destroy(&m_mutex); - throw thread_resource_error(); + throw thread_resource_error(res); } } @@ -764,7 +764,7 @@ { res = pthread_mutex_unlock(&m_mutex); assert(res == 0); - throw lock_error(); + throw lock_error(res); } if (--m_count == 0) Index: libs/thread/src/thread.cpp =================================================================== RCS file: /cvsroot/boost/boost/libs/thread/src/thread.cpp,v retrieving revision 1.18 diff -u -r1.18 thread.cpp --- libs/thread/src/thread.cpp 5 Aug 2004 17:31:14 -0000 1.18 +++ libs/thread/src/thread.cpp 2 Oct 2004 23:52:00 -0000 @@ -160,7 +160,7 @@ int res = 0; res = pthread_create(&m_thread, 0, &thread_proxy, &param); if (res != 0) - throw thread_resource_error(); + throw thread_resource_error(res); #elif defined(BOOST_HAS_MPTASKS) threads::mac::detail::thread_init(); threads::mac::detail::create_singletons();

1 0

Re: como results?
by Aleksey Gurtovoy 03 Oct '04

03 Oct '04

Hi Bronek, > I have not stopped running regression tests on Comeau compiler; why > its results are no longer displayed on > http://www.meta-comm.com/engineering/boost-regression/developer/summary__re… They are in the reports, but because "como-win32-4.3.3-vc7.1" toolset is not marked as "required" in "status/explicit-failures-markup.xml", they are visible in the full view (http://www.meta-comm.com/engineering/boost-regression/developer/summary.html) but not the release view. The links at the top/bottom of each page allow you to switch between two. Currently, the toolset is marked as "required" if either of the following holds: 1) The compiler/configuration is known to be widely used, and/or the majority of Boost developers is committed to supporting it. The current versions of MSVC, Intel, GCC and CodeWarrior all fall into this category. or 2) The compiler/configuration is not widely used, but there are one or more Boost delevopers who consider it important enough to be included in the release criteria, and therefore volunteer to run regression tests for it, fix/mark up its failures, and generally take responsibility for driving things towards the release at reasonable speed. "intel-win32-7.1-vc6-stlport-4.5.3" is one such example. The only reason Comeau hasn't been marked as "required" so far is that it's unclear to me what its position is in regard to these two criteria. -- Aleksey Gurtovoy MetaCommunications Engineering

1 0

RFI: RMI in C++
by Francis ANDRE 03 Oct '04

03 Oct '04

Hi Listers I am looking for a good C++ package that implements something quite close to Java RMI (NO Corba/IIOP please!) , I have looked at the WWW, and the boost.org but I did not found any serious answer except the article of A Batov in the "C/C++ Users Journal" http://www.cuj.com/documents/s=8206/cujweb0304batov/ Now that the serialization library is part of boost, could this be a item to add the the wishlist at boost.org??? Regards FA

6 11

Python/Linux markup
by Aleksey Gurtovoy 02 Oct '04

02 Oct '04

Should we mark Boost.Python as unusable with gcc 2.95.3/Intel 7.1-8.0 on Linux? The number of failures for these looks unhealthy -- http://tinyurl.com/5z3hy. -- Aleksey Gurtovoy MetaCommunications Engineering

4 19

basic_cstring_test/vacpp failure
by Gennadiy Rozental 02 Oct '04

02 Oct '04

This test fails in MPL "/home/tk/boost_regression/boost/boost/mpl/joint_view.hpp", line 57.48: 1540-0416 (S) "begin" cannot be declared because its name has already been used. "/home/tk/boost_regression/boost/boost/mpl/joint_view.hpp", line 46.13: 1540-0426 (I) The name "begin" is used on line 46 of "/home/tk/boost_regression/boost/boost/mpl/joint_view.hpp". Any chance for it to be fixed? Gennadiy.

2 1

[serialization] test_level_class_info_load*...
by Stefan Slapeta 02 Oct '04

02 Oct '04

...is marked as expected failure for all toolsets! Is this really intended? (What does us tell a test that is expected to fail everywhere?) Stefan

1 0

Detecting gcc-3.3-darwin regression build
by Michael Stevens 02 Oct '04

02 Oct '04

Dear all, Does anyone know what Boost.Build toolset is used to build these tests? I need to force an ABI version and I was assuming it was the 'darwin' toolset. However <darwin><*><cxxflags>"-fabi-version=0" is not triggering. Thanks, Michael -- ___________________________________ Michael Stevens Systems Engineering Navigation Systems, Estimation and Bayesian Filtering http://bayesclasses.sf.net ___________________________________

3 2

[Test] Current failures
by Aleksey Gurtovoy 02 Oct '04

02 Oct '04

Gennadiy, Could you please take a look at/comment on the current Boost.Test failures as per http://tinyurl.com/5wojs? Thanks, -- Aleksey Gurtovoy MetaCommunications Engineering

5 18

test_case_template_test / borland-5.6.4
by Gennadiy Rozental 02 Oct '04

02 Oct '04

This fails due to what seems to be some compiler bug with MPL. That this test does is run following test case : template<typename Number> void test0( Number* = 0 ) { BOOST_CHECK_EQUAL( 2, Number::value ); } with all elements of following list: typedef boost::mpl::list_c<int,2,2,2,2,2,2,2> only_2; I expect 0 errors, borland produce 7, meaning that all of the comparisons fail. Any suggestions, Gennadiy.

1 0

Bad links on the web site
by Ben Hutchings 02 Oct '04

02 Oct '04

On <http://www.boost.org/more/links.htm>: "C++ Standards Committee" links to the old committee home page. This works now because of a redirection, but will presumably stop working after a while. "ANSI Store" links to the 1998 standard which is no longer available (online at least). Ben.

2 1