future: unreferenced formal parameter 'lk'
Hello, I am using boost 1.58 and when I compile my project I have this annoying warning: Warning 4 warning C4100: 'lk' : unreferenced formal parameter C:\proj\boost\include\boost\thread\future.hpp When I look at source code I can see that lk is not used: future_state::state get_state(boost::unique_lock<boost::mutex>& lk) const { if(!done) { return future_state::waiting; } else { return future_state::ready; } } It would be great to fix it for the next release. Thanks
On June 12, 2015 5:44:29 AM EDT, forumer@smartmobili.com wrote:
Hello,
I am using boost 1.58 and when I compile my project I have this annoying warning: Warning 4 warning C4100: 'lk' : unreferenced formal parameter C:\proj\boost\include\boost\thread\future.hpp
This is a warning and not an error. Relax your compiler options warnings as errors, something like that.
When I look at source code I can see that lk is not used:
future_state::state get_state(boost::unique_lock<boost::mutex>& lk) const { if(!done) { return future_state::waiting; } else { return future_state::ready; } }
It would be great to fix it for the next release.
That or submit a PR?
Thanks
HTH
_______________________________________________ Boost-users mailing list Boost-users@lists.boost.org http://lists.boost.org/mailman/listinfo.cgi/boost-users
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Le 12/06/15 12:02, Michael a écrit :
On June 12, 2015 5:44:29 AM EDT, forumer@smartmobili.com wrote:
Hello,
I am using boost 1.58 and when I compile my project I have this annoying warning: Warning 4 warning C4100: 'lk' : unreferenced formal parameter C:\proj\boost\include\boost\thread\future.hpp This is a warning and not an error. Relax your compiler options warnings as errors, something like that.
When I look at source code I can see that lk is not used:
future_state::state get_state(boost::unique_lock<boost::mutex>& lk) const { if(!done) { return future_state::waiting; } else { return future_state::ready; } }
It would be great to fix it for the next release.
The develop branch has already fixed it :) Vicente
That or submit a PR?
Thanks HTH
_______________________________________________ Boost-users mailing list Boost-users@lists.boost.org http://lists.boost.org/mailman/listinfo.cgi/boost-users
participants (3)
-
forumer＠smartmobili.com -
Michael -
Vicente J. Botet Escriba