Writing a more readable code - Boost-users - lists.preview.boost.org

newer
Re: [Boost-users] [serialization]...

Writing a more readable code

older
Re: [Boost-users]...

Alexander Shyrokov

15 Sep 2006 15 Sep '06

4:36 p.m.

How can make the following code inside of for_each more readable? void f(char*); typedef std::map TMap; TMap a; std::for_each(a.begin(),a.end(),boost::bind(f,boost::bind(&TMap::value_type::second,_1))); Is it possible to convert boost::bind(&TMap::value_type::second,_1) to a function object or a typedef name? -- Regards, Alexander. http://sjcomp.com

Reply

Sign in to reply online Use email software

Show replies by date

me22

15 Sep 15 Sep

6:55 p.m.

On 9/15/06, Alexander Shyrokov wrote:

Is it possible to convert boost::bind(&TMap::value_type::second,_1) to a function object or a typedef name?

Though it's not exactly what you're asking for, one nice way would be to use an iterator adapter that returns base_itr->second when dereferenced. I hear that it's simple to make one with Boost.Iterator. You'd then just do std::for_each( seconder(a.begin()), seconder(a.end()), boost::bind(f,_1) );

Reply

Sign in to reply online Use email software

Peter Dimov

8:15 p.m.

Alexander Shyrokov wrote:

How can make the following code inside of for_each more readable?

void f(char*); typedef std::map TMap; TMap a;

std::for_each(a.begin(),a.end(),boost::bind(f,boost::bind(&TMap::value_type::second,_1)));

I use indentation: std::for_each( a.begin(), a.end(), boost::bind( f, boost::bind( &TMap::value_type::second, _1 ) ) ); or a custom for_each for maps: template void for_each_pair( It first, It last, F f ) { for( ; first != last; ++first ) { f( first->first, first->second ); } } for_each_pair( a.begin(), a.end(), boost::bind( f, _2 ) );

Reply

Sign in to reply online Use email software

Alexander Shyrokov

16 Sep 16 Sep

1:33 a.m.

template void for_each_pair( It first, It last, F f ) { for( ; first != last; ++first ) { f( first->first, first->second ); } }

for_each_pair( a.begin(), a.end(), boost::bind( f, _2 ) ); Could you explain why _2 is used? It looks like f parameter should have two parameters and we are using bind to use only 2nd parameter and ignore the first one? Is it correct?

The second question: why last is not a constant and maybe taken by reference? void for_each_pair( It first, const It& last, F f ) Thanks. -- Regards, Alexander. http://sjcomp.com

Reply

Sign in to reply online Use email software

me22

2:03 a.m.

On 9/15/06, Alexander Shyrokov wrote:

Could you explain why _2 is used? It looks like f parameter should have two parameters and we are using bind to use only 2nd parameter and ignore the first one? Is it correct?

boost::bind( f, _2 ) is generating a binary functor that, when called, calls the unary function f and passes it the second argument to the functor.

The second question: why last is not a constant and maybe taken by reference? void for_each_pair( It first, const It& last, F f )

Iterators are supposed to be cheap to copy and as far as I can tell it's just the usual way to pass the end iterator. There might also be some weird issues with argument deduction in some compilers. ( I seem to recall something about that... ) HTH, Scott

Reply

Sign in to reply online Use email software

Jens Theisen

1:45 p.m.

Alexander Shyrokov writes:

Is it possible to convert boost::bind(&TMap::value_type::second,_1) to a function object or a typedef name?

Yes: boost::function< void (TMap::value_type) > proc = boost::bind(f, boost::bind(&TMap::value_type::second, _1)); would do it if the signatures did match (f is taking char*, not char). Also, some boost:: q are redundant (ADL): boost::function< void (TMap::value_type) > proc = bind(f, bind(&TMap::value_type::second, _1)); Regards, Jens

Reply

Sign in to reply online Use email software

6735

Age (days ago)

6736

Last active (days ago)

Download

5 comments

4 participants

tags

participants (4)

Alexander Shyrokov
Jens Theisen
me22
Peter Dimov