[BGL] Implementing own graph types: Overloading in namespace boost or ADL?

Philipp Moeller

23 Mar 2012 23 Mar '12

2:04 p.m.

The documentation does not explicitly mention which of both approaches is recommended to implement the free function of the graph concepts for a custom graph. Usually the graph will be in its own namespace. Should the free functions be declared in the boost namespace or in the same namespace as the graph? This also would determine if BGL functions should be called qualified or unqualified outside of namespace boost. -- Philipp Moeller GeometryFactory

Show replies by date

Jeremiah Willcock

23 Mar 23 Mar

5:28 p.m.

New subject: [BGL] Implementing own graph types: Overloading in namespace boost or ADL?

On Fri, 23 Mar 2012, Philipp Moeller wrote:

...

The documentation does not explicitly mention which of both approaches is recommended to implement the free function of the graph concepts for a custom graph. Usually the graph will be in its own namespace.

Should the free functions be declared in the boost namespace or in the same namespace as the graph?

In the same namespace as the graph.

...

This also would determine if BGL functions should be called qualified or unqualified outside of namespace boost.

They should be called unqualified; I try to make sure that examples do that so that they will work on user-defined graph types. -- Jeremiah Willcock

Philipp Moeller

8:04 p.m.

New subject: [BGL] Implementing own graph types: Overloading in namespace boost or ADL?

Jeremiah Willcock writes:

...

On Fri, 23 Mar 2012, Philipp Moeller wrote:

...
The documentation does not explicitly mention which of both approaches is recommended to implement the free function of the graph concepts for a custom graph. Usually the graph will be in its own namespace.

Should the free functions be declared in the boost namespace or in the same namespace as the graph?

In the same namespace as the graph.

Maybe that should be stated explicitly somewhere.

...

...
This also would determine if BGL functions should be called qualified or unqualified outside of namespace boost.

They should be called unqualified; I try to make sure that examples do that so that they will work on user-defined graph types.

The LEDA example [1] does exactly the opposite. Probably that would be a good start.

...

-- Jeremiah Willcock

-- Philipp Moeller GeometryFactory [1] : http://www.boost.org/doc/libs/1_49_0/libs/graph/doc/leda_conversion.html

Jeremiah Willcock

8:10 p.m.

New subject: [BGL] Implementing own graph types: Overloading in namespace boost or ADL?

On Fri, 23 Mar 2012, Philipp Moeller wrote:

...

Jeremiah Willcock writes:

...
On Fri, 23 Mar 2012, Philipp Moeller wrote:

...
The documentation does not explicitly mention which of both approaches is recommended to implement the free function of the graph concepts for a custom graph. Usually the graph will be in its own namespace.

Should the free functions be declared in the boost namespace or in the same namespace as the graph?

In the same namespace as the graph.

Maybe that should be stated explicitly somewhere.

OK. That is the general rule for defining functions to use with generic libraries (for example, operators for iterators).

...

...
...
This also would determine if BGL functions should be called qualified or unqualified outside of namespace boost.

They should be called unqualified; I try to make sure that examples do that so that they will work on user-defined graph types.

The LEDA example [1] does exactly the opposite. Probably that would be a good start.

The problem there is that C++ doesn't have good ways to adapt third-party libraries to work together without adding things into the namespace of one of the libraries. The correct way to write that example would be to put the functions into the LEDA namespace so that they can be found by ADL. -- Jeremiah Willcock

4719

Age (days ago)

4719

Last active (days ago)

List overview

Download

3 comments

2 participants

participants (2)

Jeremiah Willcock
Philipp Moeller