Hi, Please take a look at the code below. The point is that for_each_treenode calls for_each_treenode_child. It seems to me that bind(Print, ref(cout), _1)(&t); is not the same as Print(cout, &t); But if this is the case, how come that for_each_treenode_child(&t, bind(Print, ref(cout), _1)); compiles and works without problem? The compiler I use is VC 7.1. Thx, Gus ---------------------------------------------------------------------- // xBindTemplFuncPtr.cpp : Defines the entry point for the console application. // #include "stdafx.h" #include <iostream> #include <vector> #include <string> #include <boost/bind.hpp> #include <boost/ref.hpp> using namespace std; using namespace boost; template<typename TTree, typename TFunc> void for_each_treenode_child(TTree* t, TFunc f) { for_each(t->children.begin(), t->children.end(), f ); } template<typename TTree, typename TFunc> void for_each_treenode(TTree *t, TFunc f) { void (*thisFunc)(TTree*, TFunc) = for_each_treenode; // COMPILER BUG WORKAROUND - NOT RELEVANT NOW for_each_treenode_child( t, boost::bind(thisFunc, _1, f) ); f(t); } struct Tree { typedef vector<Tree*> Container; typedef Container::const_iterator const_iterator; typedef Container::iterator iterator; const_iterator begin() const { return children.begin(); } const_iterator end() const { return children.end(); } iterator begin() { return children.begin(); } iterator end() { return children.end(); } Tree(const string& sData):data(sData) {} vector<Tree*> children; string data; }; void Print(ostream& out, const Tree* pTree) { out << pTree->data << " "; } void PrintStd(const Tree* pTree) { Print(cout, pTree); } int _tmain(int argc, _TCHAR* argv[]) { Tree t("t"), t1("t1"), t2("t2"), t11("t11"), t12("t12"), t21("t21"); t.children.push_back(&t1); t1.children.push_back(&t11); t1.children.push_back(&t12); t.children.push_back(&t2); t2.children.push_back(&t21); Print(cout, &t); // WORKS bind(Print, ref(cout), _)(&t); // GENERATES ERROR (1) for_each_treenode(&t, bind(Print, ref(cout), _1)); // GENERATES ERROR (2) cout << endl; for_each_treenode(&t, PrintStd); // WORKS cout << endl; for_each_treenode_child(&t, bind(Print, ref(cout), _1)); // WORKS cout << endl; return 0; } ------------------------------------------------------------------------ Error for (1): error C2664: 'boost::_bi::bind_t<R,F,L>::result_type boost::_bi::bind_t<R,F,L>::operator ()<Tree*__w64 >(A1 & ) const' : cannot convert parameter 1 from 'Tree *__w64 ' to 'Tree *__w64 & ' with [ R=void, F=void (__cdecl *)(std::ostream &,const Tree *), L=boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ostr eam>,boost::arg< 1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost:: arg<1>>::B2>, A1=Tree *__w64 ] A reference that is not to 'const' cannot be bound to a non-lvalue Error for (2): c:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\boost\bind.hpp(246) : error C2664: 'void (TTree *,TFunc)' : cannot convert parameter 2 from 'boost::_bi::result_traits<R,F>::type' to 'boost::_bi::bind_t<R,F,L>' with [ TTree=Tree, TFunc=boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>> ] and [ R=void, F=void (__cdecl *)(std::ostream &,const Tree *) ] and [ R=void, F=void (__cdecl *)(std::ostream &,const Tree *), L=boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ostr eam>,boost::arg< 1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost:: arg<1>>::B2> ] Expressions of type void cannot be converted to other types c:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\boost\bind\bind_template.hpp(33) : see reference to function template instantiation 'R boost::_bi::list2<A1,A2>::operator ()<boost::_bi::bind_t<R,F,L>::result_type,void(__cdecl *)(TTree *,TFunc),boost::_bi::list1<Tree & >>(boost::_bi::type<T>,void,A &)' being compiled with [ R=boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>:: result_type, A1=boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B1, A2=boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B2, F=void (__cdecl *)(std::ostream &,const Tree *), L=boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ostr eam>,boost::arg< 1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost:: arg<1>>::B2>, TTree=Tree, TFunc=boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>, T=boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,bo ost::arg<1>>::B2>>::result_type, A=boost::_bi::list1<Tree *& > ] c:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\algorithm(21) : see reference to function template instantiation 'boost::_bi::bind_t<R,F,L>::result_type boost::_bi::bind_t<R,F,L>::operator ()<std::allocator<_Ty>::value_type>(A1 & )' being compiled with [ R=void, F=void (__cdecl *)(Tree *,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>), L=boost::_bi::list2<boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<v oid,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B1,boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B2>, _Ty=Tree *, A1=std::allocator<Tree *>::value_type ] c:\PROG\VCPP\xBindTemplFuncPtr\xBindTemplFuncPtr.cpp(18) : see reference to function template instantiation '_Fn1 std::for_each<std::vector<_Ty>::iterator,TFunc>(_InIt,_InIt,_Fn1)' being compiled with [ _Fn1=boost::_bi::bind_t<void,void (__cdecl *)(Tree *,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>), boost::_bi::list2<boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<voi d,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B1,boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B2>>, _Ty=Tree *, TFunc=boost::_bi::bind_t<void,void (__cdecl *)(Tree *,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>), boost::_bi::list2<boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<voi d,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B1,boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<s td::ostream>,boost::arg<1>>::B2>>>::B2>>, _InIt=std::vector<Tree *>::iterator ] c:\PROG\VCPP\xBindTemplFuncPtr\xBindTemplFuncPtr.cpp(29) : see reference to function template instantiation 'void for_each_treenode_child<TTree,boost::_bi::bind_t<R,F,L>>(TTree *,TFunc)' being compiled with [ TTree=Tree, R=void, F=void (__cdecl *)(Tree *,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>), L=boost::_bi::list2<boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<v oid,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B1,boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B2>, TFunc=boost::_bi::bind_t<void,void (__cdecl *)(Tree *,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>), boost::_bi::list2<boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<voi d,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>>>: :B1,boost::_bi::list_av_2<boost::arg<1>,boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::refere nce_wrapper<std::ostream>,boost::arg<1>>::B2>>>::B2>> ] c:\PROG\VCPP\xBindTemplFuncPtr\xBindTemplFuncPtr.cpp(68) : see reference to function template instantiation 'void for_each_treenode<Tree,boost::_bi::bind_t<R,F,L>>(TTree *,TFunc)' being compiled with [ R=void, F=void (__cdecl *)(std::ostream &,const Tree *), L=boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ostr eam>,boost::arg< 1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost:: arg<1>>::B2>, TTree=Tree, TFunc=boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>> ] c:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\boost\bind.hpp(246) : error C2664: 'void (TTree *,TFunc)' : cannot convert parameter 1 from 'boost::_bi::result_traits<R,F>::type' to 'Tree *' with [ TTree=Tree, TFunc=boost::_bi::bind_t<void,void (__cdecl *)(std::ostream &,const Tree *),boost::_bi::list2<boost::_bi::list_av_2<boost::reference_wrapper<std::ost ream>,boost::arg <1>>::B1,boost::_bi::list_av_2<boost::reference_wrapper<std::ostream>,boost: :arg<1>>::B2>> ] and [ R=void, F=void (__cdecl *)(std::ostream &,const Tree *) ] Expressions of type void cannot be converted to other types
Agoston Bejo wrote:
Hi, Please take a look at the code below. The point is that for_each_treenode calls for_each_treenode_child. It seems to me that bind(Print, ref(cout), _1)(&t); is not the same as Print(cout, &t); But if this is the case, how come that for_each_treenode_child(&t, bind(Print, ref(cout), _1)); compiles and works without problem?
[...]
Print(cout, &t); // WORKS bind(Print, ref(cout), _)(&t); // GENERATES ERROR (1)
The error is caused by the fact that &t is an rvalue. Tree * pt = &t; bind(Print, ref(cout), _1)(pt); // should work
for_each_treenode_child(&t, bind(Print, ref(cout), _1)); // WORKS for_each_treenode(&t, bind(Print, ref(cout), _1)); // GENERATES ERROR (2)
This is a bit more convoluted. The problem is that for_each_treenode uses bind(Print, ref(cout), _1) as an argument to bind. The inner bind is interpreted as a nested bind expression and evaluated. Use either for_each_treenode(&t, protect(bind(Print, ref(cout), _1))); // should work or change the bind in for_each_treenode to bind(thisFunc, _1, protect(f)). protect lives in <boost/bind/protect.hpp>.
Peter Dimov wrote:
Agoston Bejo wrote:
Hi, Please take a look at the code below. The point is that for_each_treenode calls for_each_treenode_child. It seems to me that bind(Print, ref(cout), _1)(&t); is not the same as Print(cout, &t); But if this is the case, how come that for_each_treenode_child(&t, bind(Print, ref(cout), _1)); compiles and works without problem?
[...]
Print(cout, &t); // WORKS bind(Print, ref(cout), _)(&t); // GENERATES ERROR (1)
The error is caused by the fact that &t is an rvalue.
Tree * pt = &t; bind(Print, ref(cout), _1)(pt); // should work
for_each_treenode_child(&t, bind(Print, ref(cout), _1)); // WORKS for_each_treenode(&t, bind(Print, ref(cout), _1)); // GENERATES ERROR (2)
This is a bit more convoluted. The problem is that for_each_treenode uses bind(Print, ref(cout), _1) as an argument to bind. The inner bind is interpreted as a nested bind expression and evaluated. Use either
for_each_treenode(&t, protect(bind(Print, ref(cout), _1))); // should work
or change the bind in for_each_treenode to bind(thisFunc, _1, protect(f)).
protect lives in <boost/bind/protect.hpp>.
I think, Mr. Dimov, if you could document 'protect' and 'apply' a little better in relation to boost::bind and give more exmaples of their usage, it would be helpful to many programmers running into problems such as the current one has. In particular, explaining better exactly what is meant by 'evaluated' would be helpful in the documentation to nested binds. If I am too picky asking for a clearer and slower explanation of these things in the documentation, then it is clearly my fault that I find some of them hard to understand as written.
Edward Diener wrote:
I think, Mr. Dimov, if you could document 'protect' and 'apply' a little better in relation to boost::bind and give more exmaples of their usage, it would be helpful to many programmers running into problems such as the current one has.
I am left with the impression that you think that I find the documentation perfect, have plenty of free time, but deliberately don't update it. ;-) Believe me, this is not the case. I merely find it "good enough" for a volunteer one man effort from which I have not derived (and have never expected) any monetary value. Perhaps it would be possible for you to write a short (*) Bind article that complements the current documentation? We can then decide whether and how to incorporate it in the official distribution. -- (*) Or long. ;-)
Peter Dimov wrote:
Edward Diener wrote:
I think, Mr. Dimov, if you could document 'protect' and 'apply' a little better in relation to boost::bind and give more exmaples of their usage, it would be helpful to many programmers running into problems such as the current one has.
I am left with the impression that you think that I find the documentation perfect, have plenty of free time, but deliberately don't update it. ;-)
What in the language to my comment would make you believe that ? You have greatly misinterpreted my simple suggestion or something in the tone of it. I did see your smiley, but I think you are reading into the above more than is actually there.
Believe me, this is not the case. I merely find it "good enough" for a volunteer one man effort from which I have not derived (and have never expected) any monetary value.
Fair enough. I really don't see what your deriving any monetary value has to do with your viewpoint, however. If you were well paid for the documentation would you then not find it "good enough" ?
Perhaps it would be possible for you to write a short (*) Bind article that complements the current documentation? We can then decide whether and how to incorporate it in the official distribution.
I really don't quite understand how "protect" and "apply" actually work myself, which is why I asked for a clearer explanation, with some good examples. The word "evaluate" confuses me when referring to these ideas. I was hoping that by suggesting a clearer explanation of it in the documentation I would understand how better to use these constructs. If I could understand it, I would gladly write something about it and send it to you as possible additional documentation to boost::bind, since I think very highly of boost::bind and have used it in some of my own software. I don't mean to sound dumb about "protect" and "apply" by this idea of lazy or immediate evaluation in boost::bind eludes me.
Edward Diener wrote:
Peter Dimov wrote:
Edward Diener wrote:
I think, Mr. Dimov, if you could document 'protect' and 'apply' a little better in relation to boost::bind and give more exmaples of their usage, it would be helpful to many programmers running into problems such as the current one has.
I am left with the impression that you think that I find the documentation perfect, have plenty of free time, but deliberately don't update it. ;-)
What in the language to my comment would make you believe that ?
Well, since you asked: it struck my ear that way too, and I think the reason is that the "I think, Mr. Dimov" gives the whole thing too formal a tone, almost as if you were talking down to him or demanding that he do something about it. If you had omitted those first four words it would have been a simple request; if you had omitted the "Mr. Dimov", it would have had a much more friendly tone. In some contexts "Mr. Dimov" would show respect, but in the informal context of a mailing list it has the opposite effect. From your reply you obviously didn't mean it the way it sounded to Peter and to me; no big deal--that's one of the hazards of written communication with people you've never met. Mike
At Friday 2004-06-04 07:35, Mike wrote: [elided] some contexts "Mr. Dimov" would show respect, but in the informal context of a mailing list it has the opposite effect.
From your reply you obviously didn't mean it the way it sounded to Peter and to me; no big deal--that's one of the hazards of written communication with people you've never met.
especially ones from widely divergent backgrounds and custom. Victor A. Wagner Jr. http://rudbek.com The five most dangerous words in the English language: "There oughta be a law"
participants (5)
-
Agoston Bejo -
Edward Diener -
Michael Glassford -
Peter Dimov -
Victor A. Wagner Jr.