Charles Brockman wrote:

Thorsten Ottosen wrote:

...

You can't use reverse iterators in transfer.

Thank you, Thorsten. I'll create an iterator to the last element and use that in the transfer.

GeneVectType::iterator othEndIter = other->geneVect.end(); --othEndIter; geneVect.transfer(geneVect.begin(), othEndIter, other->geneVect);

Um -- I'm under the impression that decrementing the iterator returned by end() is discouraged. There are containers for which that definitely would not work. I'm guessing that he would recommend something like other->geneVect.rbegin().base() instead -- presuming you've already ensured that other->geneVect isn't empty.

AMDG Nat Goodspeed wrote:

Charles Brockman wrote:

...

Thorsten Ottosen wrote:

...

You can't use reverse iterators in transfer.

Thank you, Thorsten. I'll create an iterator to the last element and use that in the transfer.

GeneVectType::iterator othEndIter = other->geneVect.end(); --othEndIter; geneVect.transfer(geneVect.begin(), othEndIter, other->geneVect);

Um -- I'm under the impression that decrementing the iterator returned by end() is discouraged. There are containers for which that definitely would not work.

It should work for any container that supports bidirectional iterators.

I'm guessing that he would recommend something like other->geneVect.rbegin().base() instead -- presuming you've already ensured that other->geneVect isn't empty.

other->geneVect.rbegin().base() is equivalent to other->getVect.end(). In Christ, Steven Watanabe

AMDG Scott McMurray wrote:

2009/9/9 Steven Watanabe :

...

Nat Goodspeed wrote:

...

Um -- I'm under the impression that decrementing the iterator returned by end() is discouraged. There are containers for which that definitely would not work.

It should work for any container that supports bidirectional iterators.

...except std::vector, iirc.

The ability to decrement any bidirectional iterator except begin() is required by the standard. All Bidirectional iterators /must/ support this, including the iterators of std::vector. (See 24.1.4, Table 75) In Christ, Steven Watanabe

Steven Watanabe wrote:

The ability to decrement any bidirectional iterator except begin() is required by the standard. All Bidirectional iterators /must/ support this, including the iterators of std::vector. (See 24.1.4, Table 75)

I guess I was conflating the case of (iterator returned by a bidirectional container's end()) with (end-marker iterator obtained by default-constructing certain types of iterators). I'm glad to learn that you can reliably decrement the iterator returned by end(), providing it's not equal to the iterator returned by begin().

Sebastian Theophil wrote:

Internally, the boost::reverse_iterator you propose also has to decrement, so it doesn't work any better. Additionally, your proposed solution crashes because other->geneVect.rbegin().base() returns in fact other->geneVect.end(). Only *other->geneVect.rbegin() returns *(other->geneVect.end()-1).

Thanks, Steven and Sebastian. I've learned something today.