crc.hpp and visual studio run time checking
There are a few places in crc.hpp where the following happens: static value_type shift( value_type rem ) { return rem << CHAR_BIT; } The problem is, if run time checking is active in VS2003 (I assume 2005 has the same issue), a pop-up warning is issued during every call to the function as data is lost. (that's the intent in fact). The fix is to mask (rem << CHAR_BIT) & 0xffff (or whatever the appropriate mask value is for value_type). Is this a known issue? It's technically not a bug but could cause some annoyances for anybody using rtc. Should this be changed? ------------------------------ Trevor R.H. Clarke tclarke at ball com mailto:tclarke@ball.com Ball Aerospace & Technologies Corp
On 12/14/05 2:32 PM, "Clarke, Trevor"
There are a few places in crc.hpp where the following happens: static value_type shift( value_type rem ) { return rem << CHAR_BIT; }
The problem is, if run time checking is active in VS2003 (I assume 2005 has the same issue), a pop-up warning is issued during every call to the function as data is lost. (that¹s the intent in fact). The fix is to mask (rem << CHAR_BIT) & 0xffff (or whatever the appropriate mask value is for value_type). Is this a known issue? It¹s technically not a bug but could cause some annoyances for anybody using rtc. Should this be changed?
What's the point of the mask? The affected bits have already gone to oblivion at that point. Maybe RTC has a bug? -- Daryle Walker Mac, Internet, and Video Game Junkie darylew AT hotmail DOT com
participants (2)
-
Clarke, Trevor -
Daryle Walker