TR: [Boost.Filesystem] Missing inline keywords in I18N branch
Hi, Ive already sent this email but Ive not seen any reply, maybe Ive missed it. In order to take advantage of the I18N/HEAD CVS merging and after Ive checked that the inline declarations are always missed; I post again my corrections in convenience.hpp for decode_system_message () declaration and fstream.hpp for narrow_path() declaration, see the attached files for diff. Could you confirm these corrections? Best regards, Marc Viala, PhD Directeur Général/Directeur Technique 122 rue de la Roche-de-Lorzier 38430 MOIRANS Tél : +33 (0)4 76 91 37 60 Fax : +33 (0)4 76 35 00 07 http://www.acticm.com www.acticm.com mailto:mviala@acticm.com mailto:mviala@acticm.com _____ De : Marc Viala Envoyé : mardi 6 décembre 2005 21:54 À : 'boost-users@lists.boost.org' Objet : [Boost.Filesystem] Missing inline keywords in I18N branch Hi, Im not really sure but I think there are some missing inline declarations in convenience.hpp and fstream.hpp of Boost.fileystem for the I18N branch. Ive joined the patched files Could you confirm these observations? Marc Viala http://www.acticm.com www.acticm.com mailto:mviala@acticm.com mailto:mviala@acticm.com
"Marc VIALA"
Hi,
I've already sent this email but I've not seen any reply, maybe I've missed it.
Sorry, I missed your original message.
In order to take advantage of the I18N/HEAD CVS merging and after I've checked that the "inline" declarations are always missed; I post again my corrections in "convenience.hpp" for decode_system_message () declaration and "fstream.hpp" for narrow_path() declaration, see the attached files for diff.
Could you confirm these corrections?
I made the convenience.hpp correction in CVS as you indicated, and also for the other overload. In fstream.hpp, narrow_path() is a larger function, and gets called a number of times. So the best fix to avoid ODR violations is, I think, to move the declaration to a library translation unit. I don't want to do that tonight - I'm tired and would mess it up. Thanks for the report, --Beman
participants (2)
-
Beman Dawes
-
Marc VIALA