I would like to submit a patch for the Graph library. (This is the iterator splitting issue I raised some time ago.) So what is the procedure? 1) check out source from sourceforge SVN (done) 2) make changes 3) run tests??? (what is the best way to ensure the behavior has not changed?) 4) generate the patch (use svn diff?) 5) submit somewhere I just want to be sure I'm pulling the correct tree and there is some means to run regressions on my changes. Thanks. THK -- Timothy H. Keitt Associate Professor Section of Integrative Biology University of Texas at Austin http://www.keittlab.org/
What does the patch do again? 1) check out source from sourceforge SVN (done) Patches should probably be made against: https://svn.boost.org/svn/boost/. I'm not how SF matches against this repo.
2) make changes 3) run tests??? (what is the best way to ensure the behavior has not changed?)
Add specific test files to libs/graph/test. Rebuild/run all of the tests - just type bjam. The testing framework will report any failures.
4) generate the patch (use svn diff?)
Yup.
5) submit somewhere
You can submit on the list. I'll review it, we'll discuss it and it will be accepted (or not). If the patch fundamentally alters the semantics of the concepts or default behavior of existing data structures, I probably won't accept it since it will break existing code. Andrew Sutton andrew.n.sutton@gmail.com
At 2:32 PM -0400 5/28/09, Andrew Sutton wrote:
Tim Keitt
wrote: 5) submit somewhere You can submit on the list. I'll review it, we'll discuss it and it will be accepted (or not). If the patch fundamentally alters the semantics of the concepts or default behavior of existing data structures, I probably won't accept it since it will break existing code.
I would suggest that you attach the patch to a Trac ticket, and announce it on-list. That makes it much harder to miss.... -- -- Marshall Marshall Clow Idio Software mailto:marshall@idio.com It is by caffeine alone I set my mind in motion. It is by the beans of Java that thoughts acquire speed, the hands acquire shaking, the shaking becomes a warning. It is by caffeine alone I set my mind in motion.
Oops. Wrong list.
THK
On Thu, May 28, 2009 at 1:15 PM, Tim Keitt
I would like to submit a patch for the Graph library. (This is the iterator splitting issue I raised some time ago.)
So what is the procedure?
1) check out source from sourceforge SVN (done) 2) make changes 3) run tests??? (what is the best way to ensure the behavior has not changed?) 4) generate the patch (use svn diff?) 5) submit somewhere
I just want to be sure I'm pulling the correct tree and there is some means to run regressions on my changes.
Thanks.
THK
-- Timothy H. Keitt Associate Professor Section of Integrative Biology University of Texas at Austin http://www.keittlab.org/
-- Timothy H. Keitt Associate Professor Section of Integrative Biology University of Texas at Austin http://www.keittlab.org/
participants (3)
-
Andrew Sutton
-
Marshall Clow
-
Tim Keitt