[Boost.Test] warning C4265 when including <boost/test/unit_test.hpp> and friends
Just trying out Boost 1.34.1RC3, I found this in
"Pierre-Jules Tremblay"
Just trying out Boost 1.34.1RC3, I found this in
, lines 65-70: #ifdef __GNUC__ #define BOOST_TEST_PROTECTED_VIRTUAL virtual #else #define BOOST_TEST_PROTECTED_VIRTUAL #endif
perhaps the condition should be changed to include MSVC8(SP1), to eliminate multiple copies of this annoying warning:
xxxxx.hpp(54) : warning C4265: 'boost::unit_test::test_observer' : class has virtual functions, but destructor is not virtual
I'd prefer to turn it off on compiler options level. I just didn't find proper options for gcc. Gennadiy
Just for my personal culture, given that your object will have a
vtable anyway, what's wrong with a virtual dtor() ?
Cheers,
pj
On 7/23/07, Gennadiy Rozental
"Pierre-Jules Tremblay"
wrote in message news:4590bfef0707230604u76fcfed5qa76adee74b3f2b33@mail.gmail.com... Just trying out Boost 1.34.1RC3, I found this in
, lines 65-70: #ifdef __GNUC__ #define BOOST_TEST_PROTECTED_VIRTUAL virtual #else #define BOOST_TEST_PROTECTED_VIRTUAL #endif
perhaps the condition should be changed to include MSVC8(SP1), to eliminate multiple copies of this annoying warning:
xxxxx.hpp(54) : warning C4265: 'boost::unit_test::test_observer' : class has virtual functions, but destructor is not virtual
I'd prefer to turn it off on compiler options level. I just didn't find proper options for gcc.
Gennadiy
_______________________________________________ Boost-users mailing list Boost-users@lists.boost.org http://lists.boost.org/mailman/listinfo.cgi/boost-users
participants (2)
-
Gennadiy Rozental
-
Pierre-Jules Tremblay