
1 Jul
2010
1 Jul
'10
6:05 p.m.
Hi John, Thanks for your reply. My reading of the code is that it does indeed work correctly if char is unsigned - it just ends up making some comparisons which resolve to compile-time constants, which generates warnings if GCC is given the right flags. The patch you linked looks like it should fix the problem, though I have not tested it. In the short term I am looking into removing the -funsigned-char flag from our builds, since AFAICT it is not necessary. Thanks again, -Gabe