good stuff.
Anyways It be cool that assign library also gets updated so that it can
integerate well with unordered_map and unordered_sets.
It should be easy to fix... those are map.hpp and set.hpp from
boost/assign/std folder.
On Dec 19, 2007 12:33 PM, Ion Gaztañaga
Hi to all,
The Unordered library submitted by Daniel James has been *accepted* into Boost. Thanks to all reviewers and all who contributed to the library before the review.
We've received 8 reviews (Thosten Ottosen, Chun Ping Wang, Hervé Brönnimann, John Torjo, Cromwell Enage, Jamie Allsop, Graham Mark and Paul Bristow), and all were positive (since Chun's only complain was packaging and his ratings were all above 7 out of 10). Darren Cook privately sent me a positive mini-review (attached below). If I've missed any review, please let me know.
I plan to write a post this weekend with a summary of requests/suggestions and Daniel's replies.
Congrats Daniel!
Regards,
Ion
/////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////
Hi Ion, Not critical but the images seem to be missing. E.g. on http://igaztanaga.drivehq.com/unordered/unordered/buckets.html
If I find time I will try out the library and write a review in the week, but here is a mini-review (feel free to forward to the list - I'm not subscribed at the moment):
Documentation: * Fine
* The concrete examples of how to use a custom type, and a custom hash function, and do everything in portable TR1, are wonderful - I've searched before and never been able to find something as clear as this seems to be.
* In Table 1.4: "No equivalent. No idea why." is not very Boost-like :-) . Isn't the reason simply that there is no ordering in hash containers, so therefore no ordering function?
* What is your evaluation of the potential usefulness of the library? * Do you think the library should be accepted as a Boost library?
Yes. It is essential it gets into Boost as rapidly as possible; in fact I think it should be released as a patch to the current release. Having all of TR1 except for the hashed containers is a nasty red pimple on the otherwise very handsome nose of Boost.
In particular, Visual C++ *still* does not ship with TR1 ("no plans until 2009" was the rumour I found), so anyone wanting to ship portable code is relying on Boost. And, at least for me, unordered_map is the single most useful library in TR1.
Darren _______________________________________________ Boost-users mailing list Boost-users@lists.boost.org http://lists.boost.org/mailman/listinfo.cgi/boost-users