I verified the documentation changes for grid graph indexing calls and A* visitors.  Looks good.<div><br></div><div>Now doing edge weights with a static_property_map&lt;&gt;.</div><div><br></div><div>I&#39;ve duplicated relevant information from the README at the top of maze.cpp, so README doesn&#39;t need to be included in the Boost examples.<br>
<br></div><div>I found that I have to implement my own vertex index map, though I&#39;m not sure exactly why.  If I remove all my vertex index map code and call A* with the default map like so:</div><div><br></div><div><div>
    astar_search(m_barrier_grid,</div><div>                 source(),</div><div>                 heuristic,</div><div>                 boost::weight_map(weight).</div><div>                 predecessor_map(pred_pmap).</div>
<div>                 distance_map(dist_pmap).</div><div>                 visitor(visitor) );</div></div><div><br></div><div>I get the following error:</div><div><br></div><div><div>g++ -g -I/src/boost-trunk -Wall -Werror -O3   -c -o maze.o maze.cpp</div>
<div>/src/boost-trunk/boost/graph/graph_traits.hpp: In instantiation of ‘boost::vertex_property_type&lt;grid&gt;’:</div><div>/src/boost-trunk/boost/graph/filtered_graph.hpp:226:   instantiated from ‘boost::vertex_property_type&lt;boost::filtered_graph&lt;grid, boost::keep_all, boost::is_not_in_subset&lt;vertex_set&gt; &gt; &gt;’</div>
<div>/src/boost-trunk/boost/graph/properties.hpp:202:   instantiated from ‘boost::detail::vertex_property_map&lt;boost::filtered_graph&lt;grid, boost::keep_all, boost::is_not_in_subset&lt;vertex_set&gt; &gt;, boost::vertex_index_t&gt;’</div>
<div>/src/boost-trunk/boost/graph/properties.hpp:251:   instantiated from ‘boost::property_map&lt;boost::filtered_graph&lt;grid, boost::keep_all, boost::is_not_in_subset&lt;vertex_set&gt; &gt;, boost::vertex_index_t&gt;’</div>
<div>/src/boost-trunk/boost/graph/named_function_params.hpp:243:   instantiated from ‘boost::detail::choose_default_param::bind_&lt;boost::detail::error_property_not_found, boost::filtered_graph&lt;grid, boost::keep_all, boost::is_not_in_subset&lt;vertex_set&gt; &gt;, boost::vertex_index_t&gt;’</div>
<div>/src/boost-trunk/boost/graph/named_function_params.hpp:276:   instantiated from ‘boost::detail::choose_pmap_helper&lt;boost::detail::error_property_not_found, boost::filtered_graph&lt;grid, boost::keep_all, boost::is_not_in_subset&lt;vertex_set&gt; &gt;, boost::vertex_index_t&gt;’</div>
<div>/src/boost-trunk/boost/graph/astar_search.hpp:370:   instantiated from ‘void boost::astar_search(const VertexListGraph&amp;, typename boost::graph_traits&lt;G&gt;::vertex_descriptor, AStarHeuristic, const boost::bgl_named_params&lt;P, T, R&gt;&amp;) [with VertexListGraph = filtered_grid, AStarHeuristic = euclidean_heuristic, P = astar_goal_visitor, T = boost::graph_visitor_t, R = boost::bgl_named_params&lt;boost::associative_property_map&lt;maze::solve()::dist_map&gt;, boost::vertex_distance_t, boost::bgl_named_params&lt;boost::associative_property_map&lt;maze::solve()::pred_map&gt;, boost::vertex_predecessor_t, boost::bgl_named_params&lt;maze::solve()::edge_weight_pmap, boost::edge_weight_t, boost::no_property&gt; &gt; &gt;]’</div>
<div>maze.cpp:229:   instantiated from here</div><div>/src/boost-trunk/boost/graph/graph_traits.hpp:226: error: no type named ‘vertex_property_type’ in ‘class grid’</div><div>/src/boost-trunk/boost/graph/astar_search.hpp: In function ‘void boost::astar_search(const VertexListGraph&amp;, typename boost::graph_traits&lt;G&gt;::vertex_descriptor, AStarHeuristic, const boost::bgl_named_params&lt;P, T, R&gt;&amp;) [with VertexListGraph = filtered_grid, AStarHeuristic = euclidean_heuristic, P = astar_goal_visitor, T = boost::graph_visitor_t, R = boost::bgl_named_params&lt;boost::associative_property_map&lt;maze::solve()::dist_map&gt;, boost::vertex_distance_t, boost::bgl_named_params&lt;boost::associative_property_map&lt;maze::solve()::pred_map&gt;, boost::vertex_predecessor_t, boost::bgl_named_params&lt;maze::solve()::edge_weight_pmap, boost::edge_weight_t, boost::no_property&gt; &gt; &gt;]’:</div>
<div>maze.cpp:229:   instantiated from here</div><div>/src/boost-trunk/boost/graph/astar_search.hpp:370: error: no matching function for call to ‘choose_const_pmap(boost::detail::error_property_not_found, const boost::filtered_graph&lt;grid, boost::keep_all, boost::is_not_in_subset&lt;vertex_set&gt; &gt;&amp;, boost::vertex_index_t)’</div>
<div>make: *** [maze.o] Error 1</div><div><br></div><div>I was surprised by this because I expected the filtered graph to inherit the grid graph&#39;s vertex index map like you describe.</div><div><br></div><div class="gmail_quote">
On Wed, Jul 14, 2010 at 1:43 PM, Jeremiah Willcock <span dir="ltr">&lt;<a href="mailto:jewillco@osl.iu.edu">jewillco@osl.iu.edu</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Wed, 14 Jul 2010, W.P. McNeill wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
A-Star-Maze solver is pretty much done.  The filtered_graph does make the code a lot simpler.  I used lexical_cast and Boost&#39;s random number facilities, but decided the Boost command line processing code was overkill for this example. The warnings you added about not subclassing BGL types look good.<br>

</blockquote>
<br></div>
OK.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
Two things that look like documentation errors:<br></div>
 1. On the A* search page, the examine_vertex prototype for the visitor is listed as vis.examine_vertex(u, g), but you actually need it to<div class="im"><br>
    be vis.examine_vertex(u, const g) in order for the code the build.  (This may be true for the other visitor functions as well.)  This tripped me up when<br>
    I first wrote my visitor class.  I&#39;m not sure if you want to specify the constants here, or let them be assumed.<br></div>
 2. The grid graph indexing documentation incorrectly states that you get a vertex index with get(boost::vertex_index, vertex_descriptor, const Graph&amp;).<div class="im"><br>
     The order of the last two parameters is switched.  The header actually specifies get(boost::vertex_index, const Graph&amp;, vertex_descriptor).  This<br>
    appears to be the case in the documentation for a number of the get(...) functions. <br>
</div></blockquote>
<br>
I believe I fixed both of these now.  Please check.<br>
<br>
BTW, you don&#39;t need to create your own weight map if the weights are all the same; just use something like static_property_map&lt;double&gt;(1.) as the weight map.  Also, why do you need your own vertex index map?  It appears to just forward to the grid graph&#39;s version; why not just use that one directly?  It appears that filtered_graph forwards property map requests to the underlying graph by default anyway, so you might just be able to remove that argument from your call to astar_search.  You also don&#39;t need to call num_vertices() on the underlying graph; calling it on the filtered_graph does the same thing.  Does your random_int() function re-seed the RNG to get a different answer each time?<br>

<br>
I think overall that your code is nearly ready to put in.  What did you want me to do with the README.md file?  Put that in the documentation somewhere, or is most of the content in there about building it outside Boost (where it will build with the rest of the BGL examples using Boost.Build)?<br>
<font color="#888888">
<br>
-- Jeremiah Willcock</font><br>_______________________________________________<br>
Boost-users mailing list<br>
<a href="mailto:Boost-users@lists.boost.org">Boost-users@lists.boost.org</a><br>
<a href="http://lists.boost.org/mailman/listinfo.cgi/boost-users" target="_blank">http://lists.boost.org/mailman/listinfo.cgi/boost-users</a><br></blockquote></div><br></div>