19 Dec
2008
19 Dec
'08
7:23 a.m.
Peter Klotz wrote:
Gennadiy Rozental wrote:
Peter Klotz
writes: Why not just adding the virtual destructor to make valgrind happy?
Did you try removing virtual from test_suite destructor instead?
Yes, just making ~test_suite() non virtual worsens things.
valgrind complains about twice as many "invalid read" errors.
[...]
Making ~test_unit() virtual removes all errors. Then even a non virtual ~test_suite() is no longer a problem.
So the final conclusion would be to remove virtual from ~test_suite() and add it to the base class destructor ~test_unit().
Peter, I am not convinced there is a bug inside the Boost.Test code. As far as I can tell all I am doing is legitimate. Maybe we should report this to the valgrind developers instead? Gennadiy