On 03-Sep-15 6:10 AM, Konstantin Ivlev wrote:
Hi boost community,
how about integrating NaCl support patches into the boost main-line (trunk/master), I am talking about these NaCl ports patches:
https://chromium.googlesource.com/external/naclports/+/master/ports/boost
Beside suggestion to raise this on boost-devel, I'd also suggest you explain what these patches are. I guess that NaCl is Google's Native Client thing, but beyond that, I have no idea what these patches are and what they do. Also, some quick comments: - # if defined(__CYGWIN__) || defined(__USE_GNU) + # if defined(__CYGWIN__) || defined(__USE_GNU) || defined _NEWLIB_VERSION This hunk better use the same formatting as the rest of the Boost code, that is # if defined(__CYGWIN__) || defined(__USE_GNU) || defined(_NEWLIB_VERSION) There are several other places in the patch where I'd suggest using this style as opposed to #ifndef or #ifdef - case * : option = -pthread ; libs = rt ; + case * : option = -pthread ; } This hunk can't be applied as is, you'd need to introduce a new case clause to catch NaCL. - Volodya