- Boost-users - lists.preview.boost.org

Bug in boost::format with 0 valued integer
by Simon Clift 15 Sep '03

15 Sep '03

Hi folks, There appears to be a bug in boost::format, an unitialized value problem spotted when I was using valgrind on a program of mine. The following test code illustrates the (admittedly minor?) problem: #include <boost/format.hpp> #include <iostream> using namespace std; int main() { int dummy = 5; cout << boost::format( "%05d" ) % dummy << endl; dummy = 0; cout << boost::format( "%05d" ) % dummy << endl; }; I compiled this with -g and when run with valgrind it seems that the put_last function in feed_args.hpp sends an uninitialized value into the standard library <<(int) operator when the integer to be printed is 0 and leading zeros are specified. Valgrind reports (clipped for size) on the second ::format call (but not the first) of the test code: ==28879== Conditional jump or move depends on uninitialised value(s) ==28879== at 0x40289470: (within /usr/lib/libstdc++.so.5.0.3) ... ==28879== by 0x4028F36B: std::ostream::operator<<(int) (in /usr/lib/libstdc++.so.5.0.3) ==28879== by 0x804CF8D: void boost::io::detail::(anonymous namespace)::put_last<char, std::char_traits<char>, int>(std::basic_ostream<char, std::char_traits<char> >&, int&) (feed_args.hpp:114) ==28879== by 0x804C9A2: _ZN5boost2io6detail31_GLOBAL__N_test00Fill.cppfx7Zjb3putIcSt11char_traitsIcERiEEvT1_RKNS1_11format_itemIT_T0_EERSbIS9_SA_SaIS9_EERSt19basic_ostringstreamIS9_SA_SE_E (feed_args.hpp:176) ==28879== by 0x804BF44: void boost::io::detail::distribute<char, std::char_traits<char>, int&>(boost::basic_format<char, std::char_traits<char> >&, int&) (feed_args.hpp:237) ==28879== by 0x804ABB6: _ZN5boost2io6detail4feedIcSt11char_traitsIcERiEERNS_12basic_formatIT_T0_EESA_T1_ (feed_args.hpp:246) ==28879== by 0x804A14B: boost::basic_format<char, std::char_traits<char> >& boost::basic_format<char, std::char_traits<char> >::operator%<int>(int&) (format_class.hpp:69) ... Hope this helps. Otherwise I'm enjoying using boost! Best regards --- Simon -- Simon Clift E-mail: ssclift at math dot uwaterloo dot ca Ph.D. Student Scientific Computation Group University of Waterloo Waterloo, Ontario, Canada N2L 3G1

2 2

re: copy_if
by Witz 15 Sep '03

15 Sep '03

> > template<class II, class OI, class PRED> > > std::pair<II,OI> copy_if(II ibegin, II iend, OI obegin, OI oend, > > PRED p) > > { > > for(; ibegin != iend; ++ibegin) > > { > > if(p(*ibegin)) > > { > > *obegin = *ibegin; > > if(++obegin == oend) > > break; > > } > > } > > return std::make_pair(ibegin, obegin); > > } > > > > This should check whether obegin == end before copying, in case obegin > == oend initially. I don't know whether it should stop as soon as it > finds obegin == oend or wait until it knows there's another item to be > copied. The former behaviour saves a little time in the case that no > more items are wanted once the output buffer is full. The latter > behaviour avoids the occasional need for another pass that copies > nothing, if copy_if is called repeatedly to fill an output buffer which > is then flushed. > Ben. I've tended to rely on the common sense of the user (after all i cannot detect other possible errors such as 'oend < obegin') but i suppose the following addition at the start would seem sensible: ASSERT(obegin != oend); As for your second point - the amount of time saved by 'the former behaviour' depends on how expensive the predicate is and how many times it will be called if no more satisfactory items are available. As the entries in the output buffer are overwritten as and when required there is no need in any general sense to clear it between calls and this surely obviates any advantage your proposed approach may have. Witz

1 0

Re: Boost.Python - implementing slicing on extension container class
by Steve Horne 15 Sep '03

15 Sep '03

I have solved the issues I was having from my previous email. The cause of my problem was mainly that the information I needed was in the 'Embedding' section of the Boost.Python tutorial - I am not doing embedding so it did not occur to me to look there.

1 0

How do I browse the current 'boost-users' list?
by Andrew Bache 15 Sep '03

15 Sep '03

Is it possible to browse items on this list? I posted this via email having got to this page ... http://lists.boost.org/mailman/listinfo.cgi/boost-users What is not immediatly obvious (to me) is how I browse the current status of the list. Is there a URL that displays headers of the most recent posts? Can someone please point me at it? (There is a URL on the above page for an archive). Email reply please - for obvious reasons. Thanks Andy

2 1

RE: [Boost-users] Re: copy_if
by Ben Hutchings 15 Sep '03

15 Sep '03

Witz <witz(a)nildram.co.uk> wrote: > You can find an implementation of copy_if in Boost Wiki here: > > http://www.crystalclearsoftware.com/cgi-bin/boost_wiki/wiki.pl > ?STLAlgorithmExtensions > > An extension that i find useful is the following: > > template<class II, class OI, class PRED> > std::pair<II,OI> copy_if(II ibegin, II iend, OI obegin, OI oend, > PRED p) > { > for(; ibegin != iend; ++ibegin) > { > if(p(*ibegin)) > { > *obegin = *ibegin; > if(++obegin == oend) > break; > } > } > return std::make_pair(ibegin, obegin); > } > > Here we have a finite sized sink. Items are copied from the source if > they satisfy the condition and if there is room left in the sink. The > positions reached are returned on termination of the algorithm. This should check whether obegin == end before copying, in case obegin == oend initially. I don't know whether it should stop as soon as it finds obegin == oend or wait until it knows there's another item to be copied. The former behaviour saves a little time in the case that no more items are wanted once the output buffer is full. The latter behaviour avoids the occasional need for another pass that copies nothing, if copy_if is called repeatedly to fill an output buffer which is then flushed. Ben.

1 0

BGL: finding all minimum cut sets
by Trevon Fuller 14 Sep '03

14 Sep '03

Does anyone know how to find all of the minimum size cut sets of a graph (if more than 1 exists) using the BOOST graph library? The example in the BGL book just finds 1 minimum cut set (p. 106ff.).

1 0

Cygwin: Building a static libboost_thread
by Reed Hedges 14 Sep '03

14 Sep '03

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, I have tried every combination of BUILD parameters but I can't seem to get a static libboost_thread.a on gcc/Cygwin (in "no cygwin" mode: TOOLS=gcc-nocygwin). Is it possible? I am using 1.30.2, IIRC. (If on the other hand someone knows how to get DevC++ (with msys gcc) to link against the shared library that would be helpful too) thanks reed - -- Reed Hedges reed(a)zerohour.net http://zerohour.net/~reed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (Darwin) iD8DBQE/ZHFRFK83gN8ItOQRArZRAJ9M6ohiYEoPqIjXurvdJrx07YJ4TACfcHRg 5d3XguoTJNDWGgSId/zKcEY= =t/LR -----END PGP SIGNATURE-----

1 0

Test
by Victor A. Wagner, Jr. 13 Sep '03

13 Sep '03

I haven't received anything in over a week, this is just a test of the address, please ignore. Victor A. Wagner Jr. http://rudbek.com The five most dangerous words in the English language: "There oughta be a law"

1 1

Re: copy_if
by Witz 13 Sep '03

13 Sep '03

You can find an implementation of copy_if in Boost Wiki here: http://www.crystalclearsoftware.com/cgi-bin/boost_wiki/wiki.pl?STLAlgorithm… An extension that i find useful is the following: template<class II, class OI, class PRED> std::pair<II,OI> copy_if(II ibegin, II iend, OI obegin, OI oend, PRED p) { for(; ibegin != iend; ++ibegin) { if(p(*ibegin)) { *obegin = *ibegin; if(++obegin == oend) break; } } return std::make_pair(ibegin, obegin); } Here we have a finite sized sink. Items are copied from the source if they satisfy the condition and if there is room left in the sink. The positions reached are returned on termination of the algorithm. Witz

2 1

Documentation links don't
by ygor＠comcast.net 13 Sep '03

13 Sep '03

The links for PDF/HTML documentation do not work. Thanks.

4 4